Merge pull request #3048 from braddunbar/error

Pass along `textStatus` and `errorThrown`.
jashkenas · Mar 15, 2014 · 2543be2 · 2543be2
2 parents e0b84c4 + cbaa8d1
commit 2543be2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/backbone.js b/backbone.js
@@ -1215,6 +1215,14 @@
       };
     }
 
+    // Pass along `textStatus` and `errorThrown` from jQuery.
+    var error = options.error;
+    options.error = function(xhr, textStatus, errorThrown) {
+      options.textStatus = textStatus;
+      options.errorThrown = errorThrown;
+      if (error) error.apply(this, arguments);
+    };
+
     // Make the request, allowing the user to override any Ajax options.
     var xhr = options.xhr = Backbone.ajax(_.extend(params, options));
     model.trigger('request', model, xhr, options);

diff --git a/test/sync.js b/test/sync.js
@@ -207,4 +207,15 @@
     strictEqual(this.ajaxSettings.beforeSend(xhr), false);
   });
 
+  test('#2928 - Pass along `textStatus` and `errorThrown`.', 2, function() {
+    var model = new Backbone.Model;
+    model.url = '/test';
+    model.on('error', function(model, xhr, options) {
+      strictEqual(options.textStatus, 'textStatus');
+      strictEqual(options.errorThrown, 'errorThrown');
+    });
+    model.fetch();
+    this.ajaxSettings.error({}, 'textStatus', 'errorThrown');
+  });
+
 })();