Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for "standard" NO_COLOR env variable #508

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

leovilok
Copy link
Collaborator

@leovilok leovilok commented Apr 5, 2020

@jarun
Copy link
Owner

jarun commented Apr 5, 2020

There's a list of utils in the link. See if they would add nnn to the list. This is useful!

@leovilok
Copy link
Collaborator Author

leovilok commented Apr 5, 2020

There's a list of utils in the link. See if they would add nnn to the list. This is useful!

I'm preparing a PR on their repo, if you want.

@jarun
Copy link
Owner

jarun commented Apr 5, 2020

I'm preparing a PR on their repo, if you want.

Sure thing!

@leovilok leovilok merged commit f14fb9c into jarun:master Apr 5, 2020
@leovilok leovilok deleted the no-color-env branch April 5, 2020 01:56
@leovilok
Copy link
Collaborator Author

leovilok commented Apr 5, 2020

@jarun I needed a commit ID to make the no_color PR: jcs/no_color#76

@jarun
Copy link
Owner

jarun commented Apr 5, 2020

Thank you!

@leovilok
Copy link
Collaborator Author

leovilok commented Apr 5, 2020

@jarun nnn is now listed on https://no-color.org/

@jarun
Copy link
Owner

jarun commented Apr 6, 2020

Awesome! Thank you!

@lawnowner
Copy link
Contributor

@leovilok @jarun The informal NO_COLOR standard allows the users to have colored output in their applications only if they want to, which is a good idea, but it's not a per-application setting, and thus the applications that can output colored text and also support the standard are supposed to provide an option to explicitly enable color. Also stated in their website:

User-level configuration files and per-instance command-line arguments should override $NO_COLOR.

Right now, NO_COLOR overrides NNN_COLORS.

Also, congratulations for the anniversary!

@jarun
Copy link
Owner

jarun commented Apr 13, 2020

I think we should honor NNN_COLORS, if it's not defined then honor NO_COLOR, if none of the 2 defined show default colors.

@leovilok can you please take care of this? No hurry but please keep the change minimal.

@leovilok
Copy link
Collaborator Author

@jarun @lawnowner see #515

@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants