Remove cgi DeprecationWarning (Close #604)
#605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeprecationWarning: 'cgi' is deprecated and slated for removal in Python 3.13 import cgi
|
Sorry, I didn't frequently use Python for a while... I also run the linting test locally with |
rachmadaniHaryono
approved these changes
Nov 10, 2022
|
Thank you! |
This was referenced Nov 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've checked the ToDo list and PR guidelines.
Description
Remove the DeprecationWarning
'cgi' is deprecated and slated for removal in Python 3.13.Design notes
See possible methods in #604, I choose to replace
cgiwithemail.Side effects
None since
cgiandemailare all standard libraries (https://docs.python.org/3.11/library/email.html).Test cases
I cloned the repo, made a fix and installed the updated buku using
python setup.py installinside an isolated virtualenv and it does not show the deprecation warning anymore. The linting test running locally withpython3 -m pylint bukupassed as well.Documentation
Didn't touch as I think it's not related.