Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--noClean option for watch #282

Merged
merged 1 commit into from
Oct 24, 2019
Merged

--noClean option for watch #282

merged 1 commit into from
Oct 24, 2019

Conversation

ArnaudBarre
Copy link
Contributor

When using the lib in development in a yarn workspace, the first step to clean the dist folder trigger the webpack watcher (of CRA or react-native for example) which fail to recompile. This option will enable the smoother workflow for developing side by side a library with an app.

Related discussions:

Notes:

  • I didn't add it for build because I don't see any use case for that.
  • I choose --noClean instead of --no-clean for consistency with --extractErrors

@jaredpalmer
Copy link
Owner

Can i merge?

@ArnaudBarre
Copy link
Contributor Author

Yes !

@agilgur5
Copy link
Collaborator

@allcontributors please add @ArnaudBarre for code, docs

@allcontributors
Copy link
Contributor

@agilgur5

I've put up a pull request to add @ArnaudBarre! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants