Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uncaught error when use validateField on async validation #855

Merged
merged 3 commits into from
Sep 4, 2018
Merged

Fix uncaught error when use validateField on async validation #855

merged 3 commits into from
Sep 4, 2018

Conversation

houkanshan
Copy link
Contributor

Fix #813

@houkanshan
Fix doc, validateField should be in Formik props.
80b9b4b
@houkanshan
Run gen-docs.
22a1a4a
@houkanshan
Fix uncaught error when use validateField on async validation.
efbab13 
Since we use `throw` for async error, all the errors thrown from
`runSingleFieldLevelValidation` should be caught and be recognized as
invalid message.

So just catch errors inside `runSingleFieldLevelValidation` and return
a normalized promise.
@jaredpalmer jaredpalmer merged commit 8d7d586 into jaredpalmer:master Sep 4, 2018
@snyk-bot snyk-bot mentioned this pull request Jun 8, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpalmer jaredpalmer jaredpalmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@houkanshan @jaredpalmer