Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security sanitization to silence some linters #566

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Dervish13
Copy link
Contributor

I have updated the code a little bit, to improve security.

Copy link
Owner

@jaredhendrickson13 jaredhendrickson13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

This looks fine for the most part, but the shell argument in the subprocess.call definitions should also be changed to False to support the argv style command consistently and further improve security.

@Dervish13
Copy link
Contributor Author

Hey, I have changed shell argument to False. Would you like me to squash commits, or leave it as is?

Copy link
Owner

@jaredhendrickson13 jaredhendrickson13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine as is. Thanks!

@jaredhendrickson13 jaredhendrickson13 merged commit 5f1d42a into jaredhendrickson13:master Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants