Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username does not always populate correctly in change logs when config writes occur #512

Closed
jaredhendrickson13 opened this issue Jul 16, 2024 · 0 comments · Fixed by #513
Labels
bug Something isn't working v2 Issues or PRs that apply to v2

Comments

@jaredhendrickson13
Copy link
Owner

Describe the bug

In certain cases, a successful API call that results in a config write does not retain the authenticated username and will fallback to the default, (system).

To Reproduce
Steps to reproduce the behavior:

  1. Do a fresh install of v2 on a fresh install of pfSense 2.7.2.
  2. Before signing into the UI, make any API call that writes a change to the config.
  3. Go to Diagnostics > Backup & Restore > Config History and see that the change did not retain the authenticated username

Expected behavior
All config writes performed via authenticated API calls should write the username who made the call.

pfSense Version & Package Version:

  • pfSense Version: pfSense 2.7.2 (Likely affects Plus as well)
  • Package Version: v2.0.1

Affected Endpoints:

Any that perform a config write.

Additional context

This only seems to occur if there are no active PHP sessions. After any user starts a session, the username appears in the change logs as expected.

@jaredhendrickson13 jaredhendrickson13 added bug Something isn't working v2 Issues or PRs that apply to v2 labels Jul 16, 2024
@jaredhendrickson13 jaredhendrickson13 changed the title Username does not always populate correctly in change logs when a config writes occur Username does not always populate correctly in change logs when config writes occur Jul 17, 2024
@jaredhendrickson13 jaredhendrickson13 linked a pull request Jul 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2 Issues or PRs that apply to v2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant