Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention breaking change in session handling in 0.6.0 release. #986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ the session.

### Changed

- `req#login()` and `req#logout()` regenerate the the session and clear session
- `req#login()` and `req#logout()` regenerate the session and clear session
information by default.
- `authenticate()` now requires `req.session` to exist unless `session` is explicitly set to `false`. See [Sessions docs](https://www.passportjs.org/concepts/authentication/sessions/) for using session support. Failure to address this change may result in a error after upgrading, "Error: Login sessions require session support. Did you forget to use express-session middleware?". See #939 for discussion of that error.
- `req#logout()` is now an asynchronous function and requires a callback
function as the last argument.

Expand Down