Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pre-commit hook for ruff to avoid clashes with latest version of ruff #150

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Bump pre-commit hook for ruff to avoid clashes with latest version of ruff #150

merged 1 commit into from
Oct 25, 2024

Conversation

abravalheri
Copy link
Contributor

Closes #149.

@bswck
Copy link
Contributor

bswck commented Oct 25, 2024 •
edited
Loading

Projects will most likely need a series of refactors after adopted.

@bswck
Copy link
Contributor

bswck commented Oct 25, 2024

It can turn out @jaraco may want to disable some new rules since the last version.

@abravalheri abravalheri mentioned this pull request Oct 25, 2024
Merged
2 tasks
@abravalheri abravalheri marked this pull request as ready for review October 25, 2024 17:04
@jaraco jaraco merged commit 62b6678 into jaraco:main Oct 25, 2024
14 of 16 checks passed
@abravalheri abravalheri deleted the update-ruff branch October 25, 2024 23:34
clrpackages pushed a commit to clearlinux-pkgs/pypi-keyring that referenced this pull request Nov 5, 2024
@fenrus75
pypi-keyring: Autospec creation for update from version 25.4.1 to ver…
8010469 
…sion 25.5.0

Anderson Bravalheri (1):
      Bump pre-commit hook for ruff to avoid clashes with pytest-ruff (jaraco/skeleton#150)

Jamie Beverley (2):
      fix: passing a username not associated to a credential to get_credential for WinVaultKeyring returns None
      remove faulty test assertion (presumably a result of some async dbus thing on linux?)

Jason R. Coombs (8):
      Add news fragment.
      Add news fragment.
      👹 Feed the hobgoblins (delint).
      Updated comment to match new behavior.
      Restore the indentation on the check, keeping the logic in the only place it's reachable (and limiting the diff).
      Unified the Windows.get_password and .get_credential logic through a new _resolve_credential method.
      🧎‍♀️ Genuflect to the types.
      Finalize

Tor Arvid Lund (1):
      Expand user home directory in config
clrpackages pushed a commit to clearlinux-pkgs/pypi-zipp that referenced this pull request Nov 18, 2024
@fenrus75
pypi-zipp: Autospec creation for update from version 3.20.2 to versio…
587098c 
…n 3.21.0

Anderson Bravalheri (1):
      Bump pre-commit hook for ruff to avoid clashes with pytest-ruff (jaraco/skeleton#150)

Jan Hicken (1):
      Skip `zipfile.Path.exists` check in write mode (python/cpython#126576)

Jason R. Coombs (8):
      Sort imports
      Rely on cached_property to cache values on the instance.
      Rely on save_method_args to save method args.
      Add Python 3.13 and 3.14 into the matrix. (jaraco/skeleton#151)
      Include pyproject.toml in ruff.toml.
      Require Python 3.9 or later now that Python 3.8 is EOL.
      Use extend for proper workaround.
      Finalize
clrpackages pushed a commit to clearlinux-pkgs/pypi-setuptools that referenced this pull request Nov 18, 2024
@fenrus75
pypi-setuptools: Autospec creation for update from version 75.3.0 to …
31a3432 
…version 75.4.0

Anders Theet (1):
      Use minimum requirement for jaraco.functools

Anderson Bravalheri (29):
      Bump pre-commit hook for ruff to avoid clashes with pytest-ruff (jaraco/skeleton#150)
      Bump Python version for `pyright` GHA
      Remove actions on 3.8 for macos
      Fix ruff config
      Bump min Python version in comments for typechecker configs
      Let test for deprecated codepath xfail on macOS
      Mention that type-stubs need to be contained in a package directory.
      Move setuptools._path.StrPath out of the TYPE_CHECKING check (Python 3.9+)
      Add comment explaining the origin of workaround for splituser
      Automatic updates from Ruff for Python 3.9+
      Fix remaining ruff error
      Bump version check in pkg_resources
      Remove 'm' SOABI flag that no longer exists in 3.9+
      Remove old unnecessary workaround for towncrier
      Remove conditional requirement on importlib_resources in favour of importlib.resources
      Update dependency on pyproject-hooks so that it accepts newer versions
      Removed vendored version of importlib_resources
      Add news fragments
      Remove unused vars or mark them explicitly
      Allow user to skip validation of pyproject.toml via env var
      Add news fragment
      Extract convenience wrapper of rmtree to setuptools._shutil for reuse
      Extract common pattern to remove dir if exists to setuptools._shutil
      Attempt to solve typechecking problems
      Ignore some lines for coverage
      Refactor usage of shutil.rmtree in other parts of setuptools
      Add docstring
      Extract test for shutil.rmtree callback to its own file
      Bump version: 75.3.0 → 75.4.0

Avasam (13):
      pkg_resources ANN2 autofixes
      Sync with typeshed
      Consistently using `sys.version_info` as a `NamedTuple`
      Disallow blanket and unused suppressions (PGH, RUF10)
      Add fake __getattribute__ to AbstractSandbox to let type-checkers know it has a bunch of dynamic methods
      setuptools ANN201 autofixes for fully untyped functions
      Re-enable ANN2 for setuptools
      fix mypy failure after multiple merges
      Merge TypedDict from typeshed
      Deprecation warning for setuptools.command._install
      Ruff: lint pytest
      Set Ruff's pytest's parametrize-names-type to default (tuple)
      ANN204 (missing return type for special methods) autofixes

Jason R. Coombs (9):
      Restore expectation that mkpath returns a list of the items it created.
      Remove support for returning the directories created in mkpath, unused.
      Add test capturing missed expectation.
      Correct the order of operations to ensure that failed attempts aren't cached and are thus retried on subsequent operations.
      Add Python 3.13 and 3.14 into the matrix. (jaraco/skeleton#151)
      Include pyproject.toml in ruff.toml.
      Require Python 3.9 or later now that Python 3.8 is EOL.
      Use extend for proper workaround.
      Add news fragment.

Marc Mueller (3):
      Fix formatting and imports for Python 3.9
      Update vendored packaging version to 24.2
      Fix test

dependabot[bot] (1):
      Update mypy requirement from ==1.12.* to >=1.12,<1.14
@jaraco jaraco mentioned this pull request Dec 15, 2024
Open
clrpackages pushed a commit to clearlinux-pkgs/pypi-importlib_resources that referenced this pull request Jan 16, 2025
@fenrus75
pypi-importlib_resources: Autospec creation for update from version 6…
e0efbe2 
….4.5 to version 6.5.2

Anderson Bravalheri (1):
      Bump pre-commit hook for ruff to avoid clashes with pytest-ruff (jaraco/skeleton#150)

Avasam (1):
      Fix an incompatibility (and source of merge conflicts) with projects using Ruff/isort.

Jason R. Coombs (26):
      Remove workaround for sphinx-contrib/sphinx-lint#83
      Allow the workflow to be triggered manually.
      Add Python 3.13 and 3.14 into the matrix. (jaraco/skeleton#146)
      Add workaround for broken importlib.resources when an editable sentinel is present.
      Separate bpo from Python issue numbers.
      gh-123994: Generate utf-16 file using little endian and BOM. (#123995)
      👹 Feed the hobgoblins (delint).
      Add Python 3.13 and 3.14 into the matrix. (jaraco/skeleton#151)
      Include pyproject.toml in ruff.toml.
      Require Python 3.9 or later now that Python 3.8 is EOL.
      Use extend for proper workaround.
      👹 Feed the hobgoblins (delint).
      Remove unused imports.
      Bump badge for 2025.
      Re-enable type checks.
      Apply import sort fixers from ruff.
      Add type annotations for Traversable.open.
      Remove Python 3.8 compatibility code.
      Finalize
      Consolidate MemoryTraversable._resolve.
      Replace unreachable block with simple assertion. Fixes diffcov failure.
      Add news fragment.
      Finalize
      Rely on Literal from stdlib.
      Add news fragment.
      Finalize

Kurt McKee (3):
      Demonstrate python/cpython#127012
      Catch `TraversalError`, raised by `Traversable.joinpath()`
      Resolve a `TypeError` lurking in the `read_text()` functional API

Peter St. John (2):
      Add typing-extensions as a dependency
      Update pyproject.toml

Petr Viktorin (1):
      gh-123085: _compile_importlib: Avoid copying sources before compilation (GH-124131)
clrpackages pushed a commit to clearlinux-pkgs/pypi-inflect that referenced this pull request Jan 16, 2025
@fenrus75
pypi-inflect: Autospec creation for update from version 7.4.0 to vers…
90e7f75 
…ion 7.5.0

Anderson Bravalheri (1):
      Bump pre-commit hook for ruff to avoid clashes with pytest-ruff (jaraco/skeleton#150)

Avasam (1):
      Fix an incompatibility (and source of merge conflicts) with projects using Ruff/isort.

James Addison (2):
      engine: migrate from py3.14-removed `ast` classes
      _plequal: marginally reduce cyclomatic complexity (#223)

Jason R. Coombs (10):
      Remove workaround for sphinx-contrib/sphinx-lint#83
      Allow the workflow to be triggered manually.
      Add Python 3.13 and 3.14 into the matrix. (jaraco/skeleton#146)
      Add Python 3.13 and 3.14 into the matrix. (jaraco/skeleton#151)
      Include pyproject.toml in ruff.toml.
      Require Python 3.9 or later now that Python 3.8 is EOL.
      Use extend for proper workaround.
      👹 Feed the hobgoblins (delint).
      Add news fragment.
      Finalize

Josh Stephenson (3):
      Update README.rst
      Update README.rst
      Update README.rst
clrpackages pushed a commit to clearlinux-pkgs/pypi-tempora that referenced this pull request Jan 16, 2025
@fenrus75
pypi-tempora: Autospec creation for update from version 5.7.0 to vers…
a6a2206 
…ion 5.8.0

Anderson Bravalheri (2):
      Add `--fix`  flag to ruff pre-commit hook for automatic suggestion of fixes (jaraco/skeleton#140)
      Bump pre-commit hook for ruff to avoid clashes with pytest-ruff (jaraco/skeleton#150)

Avasam (5):
      Add Protocols, remove @overload, from `.coveragerc` `exclude_also` (jaraco/skeleton#135)
      Loosen restrictions on mypy (jaraco/skeleton#136)
      Pass mypy
      Add return type to all public methods
      Fix an incompatibility (and source of merge conflicts) with projects using Ruff/isort.

Dimitri Papadopoulos Orfanos (1):
      Update to the latest ruff version (jaraco/skeleton#137)

Jason R. Coombs (17):
      Split the test dependencies into four classes (test, cover, type, check). (jaraco/skeleton#139)
      Add upstream and local sections for 'type' extra, since many projects will have 'types-*' dependencies.
      Disable mypy for now. Ref jaraco/skeleton#143
      Move overload-overlap disablement to its own line for easier diffs and simpler relevant comments.
      Add a degenerate nitpick_ignore for downstream consumers. Add a 'local' comment to delineate where the skeleton ends and the downstream begins.
      Add support for linking usernames.
      Include the trailing slash in disable_error_code(overload-overlap), also required for clean diffs.
      Remove workaround for sphinx-contrib/sphinx-lint#83
      Allow the workflow to be triggered manually.
      Finalize
      Add Python 3.13 and 3.14 into the matrix. (jaraco/skeleton#146)
      Add Python 3.13 and 3.14 into the matrix. (jaraco/skeleton#151)
      Include pyproject.toml in ruff.toml.
      Require Python 3.9 or later now that Python 3.8 is EOL.
      Use extend for proper workaround.
      Drop support for Python 3.8, now EOL.
      Finalize
clrpackages pushed a commit to clearlinux-pkgs/pypi-importlib_metadata that referenced this pull request Jan 24, 2025
@fenrus75
pypi-importlib_metadata: Autospec creation for update from version 8.…
9eb1e2e 
…5.0 to version 8.6.1

Anderson Bravalheri (1):
      Bump pre-commit hook for ruff to avoid clashes with pytest-ruff (jaraco/skeleton#150)

Avasam (1):
      Fix an incompatibility (and source of merge conflicts) with projects using Ruff/isort.

Jason R. Coombs (15):
      Remove workaround for sphinx-contrib/sphinx-lint#83
      Allow the workflow to be triggered manually.
      👹 Feed the hobgoblins (delint).
      Ensure redent is idempotent (doesn't add 8 spaces to already dedented values).
      Add Python 3.13 and 3.14 into the matrix. (jaraco/skeleton#146)
      Separate bpo from Python issue numbers.
      Add Python 3.13 and 3.14 into the matrix. (jaraco/skeleton#151)
      Include pyproject.toml in ruff.toml.
      Require Python 3.9 or later now that Python 3.8 is EOL.
      Use extend for proper workaround.
      Add support for rendering metadata where some fields have newlines (python/cpython#119650).
      When transforming the payload to a Description key, clear the payload.
      Finalize
      Fixed indentation logic to also honor blank lines.
      Finalize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bswck bswck bswck approved these changes

@jaraco jaraco jaraco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest version of ruff is pulled into tests but clashes with version in .pre-commit-hooks.yaml
3 participants
@abravalheri @bswck @jaraco