-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CloudFront service #545
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #545 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 42 43 +1
Lines 3030 3255 +225
Branches 455 480 +25
==========================================
+ Hits 3030 3255 +225
Continue to review full report at Codecov.
|
7466ed6
to
ce98a3c
Compare
efe095c
to
4f48b98
Compare
@TagadaPoe I'm going to try to get to these PRs today, sorry for the delay. Could you please update your PR to allow changes from maintainers? This needs to be rebased on develop, and the others will need to be rebased as I merge them in. Thanks! |
Related to issue jantman#539 List of implemented limits: - Alternate domain names (CNAMEs) per distribution - Cache behaviors per distribution - Origin groups per distribution - Key groups associated with a single distribution - Origins per distribution - Whitelisted cookies per cache behavior - Whitelisted headers per cache behavior - Whitelisted query strings per cache behavior - Key groups associated with a single cache behavior - Public keys in a single key group - Distributions associated with a single key group - Cookies per cache policy - Headers per cache policy - Query strings per cache policy - Distributions associated with the same cache policy - Cookies per origin request policy - Headers per origin request policy - Query strings per origin request policy - Distributions associated with the same origin request policy Unit tests implemented. The CloudFront service is considered as global, so the same usage will be reported for CloudFront, no matter which region we are using. Note: in the "Service Quotas" service, the CloudFront quotas are listed in the region "us-east-1". The AWS "Service Quotas" service does not return the applied service quotas for CloudFront, only the default quotas.
4f48b98
to
9e4f162
Compare
Thank you so much for this, and many apologies for it sitting so long! |
This has been released in 12.0.0, which is now live on PyPI and Docker Hub. Thank you so much, and apologies for the delay! |
Don't worry, thank you for the release 👍 |
Before submitting pull requests, please see the
Development documentation
and specifically the Pull Request Guidelines.
IMPORTANT: Please take note of the below checklist, especially the first three items.
Summary
Adds support for CloudFront service.
The CloudFront service is considered as global, so the same usage will be reported for CloudFront, no matter which region we are using.
Note: in the "Service Quotas" service, the CloudFront quotas are listed in the region "us-east-1".
The AWS "Service Quotas" service does not return the applied service quotas for CloudFront, only the default quotas.
Note: when rebuilding the doc, there were some changes not related to CloudFront that I did not commit. Maybe an separate documentation update will be needed ?
Pull Request Checklist
writing tests for the code, that's fine, just mention that in the summary and either
ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
include complete test coverage will usually be merged faster.
tox -e docs
connect()
andconnect_resource()
methods, inherited fromawslimitchecker.connectable.Connectable
if you're working on a GitHub issue (i.e. "issue #x - "). Please
refrain from using the "fixes #x" notation unless you are sure that the
the issue is fixed in that commit.
Contributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.