Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CloudFront service #545

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

TagadaPoe
Copy link
Contributor

@TagadaPoe TagadaPoe commented May 24, 2021

Before submitting pull requests, please see the
Development documentation
and specifically the Pull Request Guidelines.

IMPORTANT: Please take note of the below checklist, especially the first three items.

Summary

Adds support for CloudFront service.

The CloudFront service is considered as global, so the same usage will be reported for CloudFront, no matter which region we are using.

Note: in the "Service Quotas" service, the CloudFront quotas are listed in the region "us-east-1".

The AWS "Service Quotas" service does not return the applied service quotas for CloudFront, only the default quotas.

Note: when rebuilding the doc, there were some changes not related to CloudFront that I did not commit. Maybe an separate documentation update will be needed ?

Pull Request Checklist

  • All pull requests should be against the develop branch, not master.
  • All pull requests must include the Contributor License Agreement (see below).
  • Whether or not your PR includes unit tests:
    • Please make sure you have run the exact code contained in the PR locally, and it functions as desired.
    • Please make sure the TravisCI build passes or, if not, you've corrected any obvious problems identified by the tests.
  • Code should conform to the Development Guidelines:
    • pep8 compliant with some exceptions (see pytest.ini)
    • 100% test coverage with pytest (with valid tests). If you have difficulty
      writing tests for the code, that's fine, just mention that in the summary and either
      ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
      include complete test coverage will usually be merged faster.
    • Complete, correctly-formatted documentation for all classes, functions and methods.
    • documentation has been rebuilt with tox -e docs
    • Connections to the AWS services should only be made by the class's
      connect() and connect_resource() methods, inherited from
      awslimitchecker.connectable.Connectable
    • All modules should have (and use) module-level loggers.
    • Commit messages should be meaningful, and reference the Issue number
      if you're working on a GitHub issue (i.e. "issue #x - "). Please
      refrain from using the "fixes #x" notation unless you are sure that the
      the issue is fixed in that commit.
    • Git history is fully intact; please do not squash or rewrite history.

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #545 (efe095c) into develop (a829ce2) will not change coverage.
The diff coverage is 100.00%.

❗ Current head efe095c differs from pull request most recent head 9e4f162. Consider uploading reports for the commit 9e4f162 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           develop      #545    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           42        43     +1     
  Lines         3030      3255   +225     
  Branches       455       480    +25     
==========================================
+ Hits          3030      3255   +225     
Impacted Files Coverage Δ
awslimitchecker/services/__init__.py 100.00% <100.00%> (ø)
awslimitchecker/services/cloudfront.py 100.00% <100.00%> (ø)
awslimitchecker/connectable.py 100.00% <0.00%> (ø)
awslimitchecker/services/ec2.py 100.00% <0.00%> (ø)
awslimitchecker/services/ecs.py 100.00% <0.00%> (ø)
awslimitchecker/services/vpc.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a829ce2...9e4f162. Read the comment docs.

@TagadaPoe TagadaPoe force-pushed the feature/addCloudFront branch from 7466ed6 to ce98a3c Compare May 24, 2021 09:23
@TagadaPoe TagadaPoe changed the base branch from master to develop May 24, 2021 13:14
@TagadaPoe TagadaPoe force-pushed the feature/addCloudFront branch from efe095c to 4f48b98 Compare May 24, 2021 14:46
@TagadaPoe TagadaPoe marked this pull request as ready for review May 24, 2021 14:59
@TagadaPoe TagadaPoe changed the title Feature/add cloud front Add support for CloudFront service May 24, 2021
@jantman
Copy link
Owner

jantman commented Jul 9, 2021

@TagadaPoe I'm going to try to get to these PRs today, sorry for the delay. Could you please update your PR to allow changes from maintainers? This needs to be rebased on develop, and the others will need to be rebased as I merge them in. Thanks!

Related to issue jantman#539

List of implemented limits:
- Alternate domain names (CNAMEs) per distribution
- Cache behaviors per distribution
- Origin groups per distribution
- Key groups associated with a single distribution
- Origins per distribution
- Whitelisted cookies per cache behavior
- Whitelisted headers per cache behavior
- Whitelisted query strings per cache behavior
- Key groups associated with a single cache behavior
- Public keys in a single key group
- Distributions associated with a single key group
- Cookies per cache policy
- Headers per cache policy
- Query strings per cache policy
- Distributions associated with the same cache policy
- Cookies per origin request policy
- Headers per origin request policy
- Query strings per origin request policy
- Distributions associated with the same origin request policy

Unit tests implemented.

The CloudFront service is considered as global, so the same usage will be reported for CloudFront, no matter which region we are using.

Note: in the "Service Quotas" service, the CloudFront quotas are listed in the region "us-east-1".

The AWS "Service Quotas" service does not return the applied service quotas for CloudFront, only the default quotas.
@antonincms antonincms force-pushed the feature/addCloudFront branch from 4f48b98 to 9e4f162 Compare July 22, 2021 10:09
@jantman
Copy link
Owner

jantman commented Aug 4, 2021

Thank you so much for this, and many apologies for it sitting so long!

@jantman jantman merged commit b7c1630 into jantman:develop Aug 4, 2021
@antonincms antonincms deleted the feature/addCloudFront branch August 4, 2021 11:53
jantman added a commit that referenced this pull request Aug 4, 2021
@jantman
Copy link
Owner

jantman commented Aug 4, 2021

This has been released in 12.0.0, which is now live on PyPI and Docker Hub. Thank you so much, and apologies for the delay!

@antonincms
Copy link

antonincms commented Aug 4, 2021

Don't worry, thank you for the release 👍

derrix060 pushed a commit to derrix060/awslimitchecker that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants