Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda download #522

Merged
merged 5 commits into from
Apr 20, 2021
Merged

Add conda download #522

merged 5 commits into from
Apr 20, 2021

Conversation

BastianZim
Copy link
Contributor

@BastianZim BastianZim commented Feb 16, 2021

Before submitting pull requests, please see the
Development documentation
and specifically the Pull Request Guidelines.

IMPORTANT: Please take note of the below checklist, especially the first three items.

Summary

Add a summary of what your PR does here. This could be as simple as "adds support for X service" or "fixes default limit for Y", or a longer explanation for less straightforward changes.

Adds conda as a download option. Closes #520

Pull Request Checklist

  • All pull requests should be against the develop branch, not master.
  • All pull requests must include the Contributor License Agreement (see below).
  • Whether or not your PR includes unit tests:
    • Please make sure you have run the exact code contained in the PR locally, and it functions as desired.
    • Please make sure the TravisCI build passes or, if not, you've corrected any obvious problems identified by the tests.
  • Code should conform to the Development Guidelines:
    • pep8 compliant with some exceptions (see pytest.ini)
    • 100% test coverage with pytest (with valid tests). If you have difficulty
      writing tests for the code, that's fine, just mention that in the summary and either
      ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
      include complete test coverage will usually be merged faster.
    • Complete, correctly-formatted documentation for all classes, functions and methods.
    • documentation has been rebuilt with tox -e docs
    • Connections to the AWS services should only be made by the class's
      connect() and connect_resource() methods, inherited from
      awslimitchecker.connectable.Connectable
    • All modules should have (and use) module-level loggers.
    • Commit messages should be meaningful, and reference the Issue number
      if you're working on a GitHub issue (i.e. "issue #x - "). Please
      refrain from using the "fixes #x" notation unless you are sure that the
      the issue is fixed in that commit.
    • Git history is fully intact; please do not squash or rewrite history.

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.

@BastianZim BastianZim marked this pull request as ready for review February 16, 2021 11:03
@codecov-io
Copy link

codecov-io commented Feb 16, 2021

Codecov Report

Merging #522 (1386ab3) into develop (d0593d8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #522   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3005      3005           
  Branches       448       448           
=========================================
  Hits          3005      3005           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0593d8...9c7e2bc. Read the comment docs.

@BastianZim
Copy link
Contributor Author

@jantman I have now added conda and tried to follow your code style but let me know if you prefer a different phrasing or formatting somewhere.

@BastianZim
Copy link
Contributor Author

documentation has been rebuilt with tox -e docs

Just to check, I've done this locally but didn't include anything since I assumed that the CI does that. Or should I include it?

@jantman jantman merged commit 9c2d318 into jantman:develop Apr 20, 2021
@BastianZim
Copy link
Contributor Author

Thanks!

@BastianZim BastianZim deleted the add-conda-download branch April 20, 2021 21:58
@jantman
Copy link
Owner

jantman commented Apr 21, 2021

This has been released in 11.0.0, which is now live on PyPI. Thank you so much, and apologies for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants