Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #463 - ECS and Fargate limit updates #485

Merged
merged 6 commits into from
Sep 22, 2020
Merged

Fixes #463 - ECS and Fargate limit updates #485

merged 6 commits into from
Sep 22, 2020

Conversation

jantman
Copy link
Owner

@jantman jantman commented Sep 22, 2020

This PR fixes #463

  • Issue #463 - Updates for the major changes to ECS limits in August 2020
    • The EC2 Tasks per Service (desired count) limit has been replaced with Tasks per service, which measures the desired count of tasks of all launch types (EC2 or Fargate). The default value of this limit has increased from 1000 to 2000.
    • The default of Clusters has increased from 2,000 to 10,000.
    • The default of Services per Cluster has increased from 1,000 to 2,000.
    • The Fargate Tasks limit has been removed.
    • The Fargate On-Demand resource count limit has been added, with a default quota value of 500. This limit measures the number of ECS tasks and EKS pods running concurrently on Fargate. The current usage for this metric is obtained from CloudWatch.
    • The Fargate Spot resource count limit has been added, with a default quota value of 500. This limit measures the number of ECS tasks running concurrently on Fargate Spot. The current usage for this metric is obtained from CloudWatch.
  • Add internal helper method to :py~._AwsService to get Service Quotas usage information from CloudWatch.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020

Codecov Report

Merging #485 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #485   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         2879      2901   +22     
  Branches       441       441           
=========================================
+ Hits          2879      2901   +22     
Impacted Files Coverage Δ
awslimitchecker/checker.py 100.00% <ø> (ø)
awslimitchecker/services/base.py 100.00% <100.00%> (ø)
awslimitchecker/services/ecs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e8db5...9dbf08b. Read the comment docs.

@jantman jantman merged commit de35f30 into develop Sep 22, 2020
@jantman jantman deleted the issues/463 branch September 22, 2020 14:56
@jantman jantman mentioned this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants