Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DynamoDB and EFS limits #390 #391

Merged
merged 5 commits into from
Feb 26, 2019
Merged

Conversation

bergkampsliew
Copy link
Contributor

Summary

Update DynamoDB and EFS limits
More info on the issue : #390

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.

@jantman
Copy link
Owner

jantman commented Feb 26, 2019

@bergkampsliew Thank you so much for the contribution!

A number of these limits appear in the unit tests as well, hence the failed build. If you wouldn't mind updating them, that would be greatly appreciated.

If the unit tests pass, I can get this merged today and should be able to get a release out within the next 24 hours.

@bergkampsliew
Copy link
Contributor Author

yeah, i just noticed the error... committing the fix to the unit test now, thanks

@jantman
Copy link
Owner

jantman commented Feb 26, 2019

Thanks so much! Merging now. I should be able to get a release out tonight, I'll update here and on the issue once it's live on PyPI.

@jantman jantman merged commit 77414e6 into jantman:develop Feb 26, 2019
@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #391 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #391   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           30     30           
  Lines         2274   2274           
  Branches       338    338           
======================================
  Hits          2274   2274
Impacted Files Coverage Δ
awslimitchecker/services/dynamodb.py 100% <ø> (ø) ⬆️
awslimitchecker/services/efs.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aef5405...813b9bf. Read the comment docs.

@jantman
Copy link
Owner

jantman commented Feb 26, 2019

This has been released as 6.1.3 via #393 and is now live on PyPI.

Thank you so much for the contribution!

@bergkampsliew
Copy link
Contributor Author

that's really fast 🥇 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants