-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle AccessDenied exception in SES check #375 #376
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #376 +/- ##
======================================
Coverage 100% 100%
======================================
Files 30 30
Lines 2245 2256 +11
Branches 331 335 +4
======================================
+ Hits 2245 2256 +11
Continue to review full report at Codecov.
|
@bergkampsliew I commented on #375 ... Thank you for the contribution. In order to write tests for this I need a copy of the exact traceback that's being thrown along with the error message, or a region that I can try and reproduce the problem in. |
the stacktrace as below, and it's reproducible against region eu-central-1 (you can compare the result from ap-northeast-1 as both regions do not support SES yet) Traceback (most recent call last): |
Ok, thanks! I'm actually going to be really busy the next few days, but I'll try to get this merged this weekend. |
This has been released in 6.0.1 which is now live on PyPI. Thank you so much @bergkampsliew !! |
Summary
Handle AccessDenied exception in SES check for non-supported region
More info on the issue : #375
Contributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.