-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Elastic Beanstalk default values #330
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #330 +/- ##
======================================
Coverage 100% 100%
======================================
Files 25 25
Lines 1954 1954
Branches 296 296
======================================
Hits 1954 1954
Continue to review full report at Codecov.
|
Thanks! I'm going to be on vacation for the next few days, so I probably won't be able to get to this until early next week, but I'll try to get it merged ASAP. Thanks again for the contribution! |
Updated defaults for Autoscaling, EBS and IAM |
Thanks so much for this! |
This has been released just now in 4.0.0, which is now live on PyPI. |
Summary
Updates values to reflect AWS default limits for Elastic Beanstalk, Autoscaling, EBS and IAM
https://docs.aws.amazon.com/general/latest/gr/aws_service_limits.html#limits_elastic_beanstalk
Pull Request Checklist
writing tests for the code, that's fine, just mention that in the summary and either
ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
include complete test coverage will usually be merged faster.
tox -e docs
connect()
andconnect_resource()
methods, inherited fromawslimitchecker.connectable.Connectable
if you're working on a GitHub issue (i.e. "issue #x - "). Please
refrain from using the "fixes #x" notation unless you are sure that the
the issue is fixed in that commit.
Contributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.