Handle govcloud-specific edge cases. #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report@@ Coverage Diff @@
## develop #251 +/- ##
======================================
Coverage 100% 100%
======================================
Files 22 22
Lines 1648 1661 +13
Branches 257 260 +3
======================================
+ Hits 1648 1661 +13
Continue to review full report at Codecov.
|
|
@jantman: if this looks all right to you, I'll backfill tests. Let me know! |
|
@jmcarp Aplogies for this sitting for so long, I've had some family stuff going on that limited my time spent on personal projects. Looks great to me. If you can backfill the tests, I'll get this in the next release. PS - Hey, you're one of those 18F people! You rock! |
jmcarp
force-pushed
the
govcloud-edge-cases
branch
3 times, most recently
from
0d4aa24 to
37c459a
Compare
* Handle errors on spot instance and fleet requests * Handle false zero limit on EIP
jmcarp
force-pushed
the
govcloud-edge-cases
branch
from
37c459a to
30b98f7
Compare
jmcarp
force-pushed
the
govcloud-edge-cases
branch
from
30b98f7 to
33c994f
Compare
|
Thanks so much for this! |
|
This was just released in 0.8.0, which is now live on PyPI. Apologies for the long delay before this release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle govcloud-specific edge cases.
Contributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.