Treat an empty string as falsey in inverted sections. #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this bug! Alright @janl, no reason not to pull right? ;) |
|
Based on this ticket it seems like the jury is still out on whether or not mustache should defer to the host language or maintain its own rigid spec. For now, just for the sake of not breaking with backwards compatibility, I'd like to keep it the way it is (i.e. falsey values are |
|
Let's keep discussion for this issue on #186. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat an empty string (or for that matter, any value that evaluates to false) as falsey in inverted sections.
Per the spec (mustache/spec#28), a value is falsey if the host language treats it as falsey. JavaScript treats an empty string as falsey.
Fixes issue #186 (#186)