Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed collapsible rendered height #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GonzaFran
Copy link
Contributor

LINK DE TICKET:

https://janiscommerce.atlassian.net/browse/APPSRN-361

CONTEXTO:

Durante la implementación del componente collapsible de ui-native nos dimos cuenta que, al estar renderizado, el componente desplaza hacia abajo el resto de elementos en pantalla debido a que está tomando, como alto del componente, el alto total de su header + el content que debe renderizar.

NECESIDAD:

Corregir el comportamiento del componente para que, al estar cerrado, no ocupe más lugar que su header correspondiente en pantalla.

SOLUCIÓN:
Se removió la propiedad flex de los estilos del wrapper de collapsible

CÓMO PROBARLO?

  • Revisar storybooks web o mobile.

Peek 2025-02-14 16-58

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13445177182

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 13438564769: 0.0%
Covered Lines: 725
Relevant Lines: 725

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants