-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Jan Hub Revamp #4491
Merged
Merged
feat: Jan Hub Revamp #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-menlo
temporarily deployed
to
production
January 20, 2025 16:35 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 20, 2025 16:35 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 20, 2025 16:58 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 20, 2025 16:58 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 21, 2025 02:29 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 21, 2025 02:29 — with
GitHub Actions
Inactive
louis-menlo
force-pushed
the
feat/jan-hub-revamp
branch
from
January 23, 2025 04:50
bf7b068
to
0351085
Compare
louis-menlo
temporarily deployed
to
production
January 23, 2025 04:50 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 04:50 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 12:05 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 12:05 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 17:42 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 17:42 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 17:58 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 17:58 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 18:01 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 18:01 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 18:10 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 18:11 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 19:03 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 23, 2025 19:03 — with
GitHub Actions
Inactive
urmauur
approved these changes
Jan 24, 2025
louis-menlo
temporarily deployed
to
production
January 28, 2025 11:42 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 28, 2025 11:42 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 28, 2025 13:22 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 28, 2025 13:22 — with
GitHub Actions
Inactive
louis-menlo
force-pushed
the
feat/jan-hub-revamp
branch
from
January 28, 2025 15:01
160a988
to
20dc0ea
Compare
louis-menlo
temporarily deployed
to
production
January 28, 2025 15:01 — with
GitHub Actions
Inactive
louis-menlo
temporarily deployed
to
production
January 28, 2025 15:01 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR introduces support for /model/sources in Jan Model Hub, implemented using cortex.cpp.
With this endpoint support, the Jan frontend can now remove pre-populated models and legacy HuggingFace operations. All requests are now routed to the cortex.cpp server. So that:
As a user, I can now access model variants from the Cortexso Hub, along with improved model descriptions.
Demo
New Model Hub Revamp
This is a full flow of this new model hub revamp
New model search outlook
This new model search outlook functions more effectively with fuzzy searching. It supports either recent searched models or Hugging Face repository ID or URL.
Download HuggingFace models
Users can now see the search status and model founds instead of just getting an error message as before.
Download Cortexso hub models
Users can input the repository ID of the cortexso repository to work with multiple branches (model versions).
Cloud models
Instead of listing all remote models as before, which was confusing, we've created a long list that needs to be grouped. We're introducing a new remote model detail page to help organize the information.
New sorting options
Now users can sort models by
Most Downloaded
orNewest
Quick download action
Users can conveniently select model versions right on the download button, bypassing the need to go to the model detail page.
New Deeplink update
Now, instead of displaying the model dialog, it directs users to the model detail page.
Hub Banner settings
Users can now customize the Model Hub with banner settings
Fixes Issues
/model/sources
#3910Self Checklist
Changes
This pull request includes significant changes to the model management system, the integration of a new dropdown menu component, and some utility function updates. The most important changes are detailed below:
Model Management Enhancements:
getSources
,addSource
, anddeleteSource
to theModelExtension
class for managing model sources (core/src/browser/extensions/model.ts
).ModelSource
interface and related types to define the structure of model sources (core/src/types/model/modelSource.ts
).ICortexAPI
andCortexAPI
to include methods for handling model sources (extensions/model-extension/src/cortex.ts
). [1] [2]Dropdown Menu Component:
Dropdown
component using@radix-ui/react-dropdown-menu
, including styles and functionality (joi/src/core/Dropdown/index.tsx
,joi/src/core/Dropdown/styles.scss
). [1] [2]package.json
to include the new dependency for the dropdown menu (joi/package.json
).Utility Function Updates:
toGibibytes
totoGigabytes
in several files for consistency in memory size conversion (web/containers/Layout/BottomPanel/SystemMonitor/TableActiveModel/index.tsx
,web/containers/Layout/BottomPanel/SystemMonitor/index.tsx
). [1] [2] [3] [4]These changes improve the flexibility and functionality of the model management system and enhance the user interface with a new dropdown component.