chore: add caching for engines to improve load time #4481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-jan
changed the title
Barecheck - Code coverage reportTotal: 67.98%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
urmauur
approved these changes
Jan 18, 2025
|
This is the build for this pull request. You can download it from the Artifacts section here: Build URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Currently, the app waits for the cortex.cpp server to load before displaying the current model and engines, which is not user-friendly.
This PR introduces a SWR storage cache provider to eliminate any delays users experience when opening the app, especially after engine persistence.
Changes
This pull request includes several important changes to the
web/containersdirectory, focusing on improving the caching mechanism and simplifying the codebase. The most significant changes include the addition of a newSWRConfigProvidercomponent, updates to theProviderscomponent to use the new provider, and a minor simplification in theTableActiveModelcomponent.Improvements to caching mechanism:
web/containers/Providers/SWRConfigProvider.tsx: Added a newSWRConfigProvidercomponent to manage caching usinglocalStorage. This component initializes the cache fromlocalStorageand saves it back before unloading.web/containers/Providers/index.tsx: ImportedSWRConfigProviderand wrapped the existing providers with it to enable the new caching mechanism. [1] [2]Codebase simplification:
web/containers/Layout/BottomPanel/SystemMonitor/TableActiveModel/index.tsx: Simplified the conditional rendering logic by removing the unnecessaryenginescheck.Additional imports:
web/containers/Providers/index.tsx: Added import forSWRConfigto support the new caching mechanism.