Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move cortex extension settings to local engine page #4457

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

This PR is to update app local engine settings which extended from it's parent extension settings. From now on, there is no Cortex extensions page, but all settings moved to llama.cpp engine page.

CleanShot 2025-01-15 at 19 47 07

Fixes Issues

Changes

This pull request includes several changes to the Settings screen in the web application, primarily focusing on the ExtensionSetting component and related files. The changes introduce new functionality, improve existing code, and fix minor issues.

Changes to ExtensionSetting component:

  • Updated ExtensionSetting to accept an optional extensionName prop and use useMemo to determine the current extension name. This allows for more flexible usage of the component. [1] [2] [3]
  • Added import of ExtensionSetting in LocalEngineSettings.tsx and included it in the component's JSX structure. This integrates the ExtensionSetting component into the LocalEngineSettings screen. [1] [2]

Other improvements and fixes:

  • Adjusted the width of the text input for number types in SettingDetailTextInputItem to improve the layout.
  • Simplified the conditional class assignment in SettingDetailItem to remove unnecessary mx-4 class.
  • Wrapped ExtensionSetting in a div with mx-4 class in SettingDetail to ensure consistent padding.
  • Filtered out extensions with names containing 'Cortex' in SettingLeftPanel to exclude them from the settings list.

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Barecheck - Code coverage report

Total: 69.26%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@louis-jan louis-jan merged commit dd791b9 into dev Jan 15, 2025
13 of 14 checks passed
@louis-jan louis-jan deleted the feat/move-cortex-extension-settings-to-engine branch January 15, 2025 13:29
@github-actions github-actions bot added this to the v0.5.14 milestone Jan 15, 2025
@imtuyethan imtuyethan modified the milestones: v0.5.14, v0.5.15 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Move settings in Cortex page to llama.cpp page
3 participants