feat: move cortex extension settings to local engine page #4457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR is to update app local engine settings which extended from it's parent extension settings. From now on, there is no Cortex extensions page, but all settings moved to llama.cpp engine page.
Fixes Issues
Changes
This pull request includes several changes to the
Settings
screen in the web application, primarily focusing on theExtensionSetting
component and related files. The changes introduce new functionality, improve existing code, and fix minor issues.Changes to
ExtensionSetting
component:ExtensionSetting
to accept an optionalextensionName
prop and useuseMemo
to determine the current extension name. This allows for more flexible usage of the component. [1] [2] [3]ExtensionSetting
inLocalEngineSettings.tsx
and included it in the component's JSX structure. This integrates theExtensionSetting
component into theLocalEngineSettings
screen. [1] [2]Other improvements and fixes:
SettingDetailTextInputItem
to improve the layout.SettingDetailItem
to remove unnecessarymx-4
class.ExtensionSetting
in adiv
withmx-4
class inSettingDetail
to ensure consistent padding.SettingLeftPanel
to exclude them from the settings list.