Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incompatible browser dependency #2439

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

louis-menlo
Copy link
Contributor

Describe Your Changes

  • Resolve incompatibility of the ULID that does not work with the browser.
  • Resolve the build error.
  • Extensions should use Yarn.
  • Remove UMD export. Only es & cjs

Fixes Issues

  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-menlo louis-menlo requested review from urmauur and namchuai March 20, 2024 13:54
@github-actions github-actions bot added the type: bug Something isn't working label Mar 20, 2024
@louis-menlo louis-menlo force-pushed the fix/resolve-incompatible-browser-dependency branch from 089c3f0 to 775803d Compare March 21, 2024 07:53
@louis-menlo louis-menlo force-pushed the fix/resolve-incompatible-browser-dependency branch 2 times, most recently from b21c2d3 to 1832b23 Compare March 21, 2024 09:06
@louis-menlo louis-menlo merged commit ff7ec39 into dev Mar 21, 2024
7 checks passed
@louis-menlo louis-menlo deleted the fix/resolve-incompatible-browser-dependency branch March 21, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants