Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong engine handling #2363

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix: wrong engine handling #2363

merged 1 commit into from
Mar 14, 2024

Conversation

louis-menlo
Copy link
Contributor

Describe Your Changes

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-menlo louis-menlo requested review from urmauur and namchuai March 14, 2024 16:45
@github-actions github-actions bot added the type: bug Something isn't working label Mar 14, 2024
@louis-menlo louis-menlo merged commit 58e12f3 into dev Mar 14, 2024
5 of 7 checks passed
@louis-menlo louis-menlo deleted the fix/wrong-error-handling branch March 14, 2024 16:59
@Van-QA Van-QA added this to the v0.4.9 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@urmauur urmauur Awaiting requested review from urmauur

Assignees

@louis-menlo louis-menlo

Labels
type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
v0.4.9
Development

Successfully merging this pull request may close these issues.
3 participants
@louis-menlo @namchuai @Van-QA