Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some costmetic issues: badges corner, recommended for tensorrt models #2346

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix: some costmetic issues: badges corner, recommended for tensorrt models #2346

merged 1 commit into from
Mar 14, 2024

Conversation

namchuai
Copy link
Collaborator

@namchuai namchuai commented Mar 14, 2024 •
edited
Loading

Describe Your Changes

  • Fix some cosmetic issues: corner for badges and recommended tag

Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested review from louis-menlo and urmauur and removed request for louis-menlo March 14, 2024 08:48
@github-actions github-actions bot added the type: bug Something isn't working label Mar 14, 2024
louis-menlo
louis-menlo approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai mentioned this pull request Mar 14, 2024
Closed
@namchuai namchuai merged commit 03a0978 into dev Mar 14, 2024
2 of 7 checks passed
@namchuai namchuai deleted the fix/cosmetic-issue branch March 14, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-menlo louis-menlo louis-menlo approved these changes

@urmauur urmauur urmauur approved these changes

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@namchuai @urmauur @louis-menlo @jan-hiro-v