Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quick app windows, tray and dock behaviors #2327

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Mar 12, 2024

Describe Your Changes

  • Keep Jan app to stay on the dock when running, even if the main window is closed. (Hidden before)
  • Show Jan's app's main window when users click it in the dock or open it from a quick action.
  • Click on app tray icon, quick ask window should be shown
  • Should not hide main window when pressing esc

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Mar 12, 2024
@louis-jan louis-jan changed the title fix: quick app "hoạt động không hiệu quả ở background" fix: quick app Mar 12, 2024
@louis-jan louis-jan changed the title fix: quick app fix: quick app windows, tray and dock behaviors Mar 12, 2024
@louis-jan louis-jan requested review from urmauur and namchuai March 12, 2024 09:12
@louis-jan louis-jan force-pushed the fix/quick-ask-issues branch from 82e79d2 to f751fb6 Compare March 12, 2024 09:17
@louis-jan louis-jan force-pushed the fix/quick-ask-issues branch from f751fb6 to c90bebd Compare March 12, 2024 09:35
@louis-jan louis-jan merged commit b9b421a into dev Mar 12, 2024
7 checks passed
@louis-jan louis-jan deleted the fix/quick-ask-issues branch March 12, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants