Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: openAIEmbedding now requires top level API Key configuration #1902

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix: openAIEmbedding now requires top level API Key configuration #1902

merged 2 commits into from
Feb 2, 2024

Conversation

louis-menlo
Copy link
Contributor

Describe Your Changes

The client api key setting is deprecated, now configure on top level

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-menlo louis-menlo requested a review from hiro-v February 2, 2024 04:47
@github-actions github-actions bot added the type: bug Something isn't working label Feb 2, 2024
@louis-menlo louis-menlo requested a review from namchuai February 2, 2024 05:01
@louis-menlo louis-menlo merged commit eaa3053 into main Feb 2, 2024
7 checks passed
@louis-menlo louis-menlo deleted the regression/retrieval-openai-api-key-config branch February 2, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiento09 hiento09 hiento09 approved these changes

@hiro-v hiro-v Awaiting requested review from hiro-v

@namchuai namchuai Awaiting requested review from namchuai

Assignees

@louis-menlo louis-menlo

Labels
type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-menlo @hiento09