Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display error message on model load fail #1894

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix: display error message on model load fail #1894

merged 1 commit into from
Feb 1, 2024

Conversation

louis-menlo
Copy link
Contributor

@louis-menlo louis-menlo commented Feb 1, 2024 •
edited
Loading

Describe Your Changes

  • Display error message when loading model failed instead of letting message queue get stuck.
  • Realign the loading indicator
Screenshot 2024-02-01 at 21 12 21

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Feb 1, 2024
@louis-menlo louis-menlo force-pushed the fix/load-model-fail-message branch 3 times, most recently from cc2dd96 to cbd98f9 Compare February 1, 2024 16:00
@louis-menlo louis-menlo force-pushed the fix/load-model-fail-message branch from cbd98f9 to 3b8b403 Compare February 1, 2024 16:05
@louis-menlo louis-menlo merged commit 5ce2e42 into dev Feb 1, 2024
7 checks passed
@louis-menlo louis-menlo deleted the fix/load-model-fail-message branch February 1, 2024 16:28
hiento09 pushed a commit that referenced this pull request Feb 2, 2024
@louis-menlo @jan-service-account
fix: display error message on model load fail (#1894)
dbf82c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@Van-QA Van-QA Awaiting requested review from Van-QA

Assignees

@louis-menlo louis-menlo

Labels
type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: message queue got stuck, models didn't respond
2 participants
@louis-menlo @namchuai