Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove unnecessary rerender when user typing input #1818

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

namchuai
Copy link
Collaborator

@namchuai namchuai commented Jan 28, 2024

Describe Your Changes

  • Reduce unnecessary rerendering ChatScreen when user typing input.

Screenshots

Before

Screen.Recording.2024-01-28.at.10.59.46.mov

After

Screen.Recording.2024-01-28.at.10.54.59.mov

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: enhancement Improves a current feature label Jan 28, 2024
@namchuai namchuai force-pushed the perf/should-not-render-chat-screen-when-typing branch 2 times, most recently from ce276ff to db2865e Compare January 28, 2024 05:23
Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

…t-new-chat

Autofocus text input when start new chat
@namchuai namchuai force-pushed the perf/should-not-render-chat-screen-when-typing branch from db2865e to c2b2735 Compare January 29, 2024 02:58
@namchuai namchuai merged commit bb47d68 into dev Jan 29, 2024
4 of 7 checks passed
@namchuai namchuai deleted the perf/should-not-render-chat-screen-when-typing branch January 29, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improves a current feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants