Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: error message when not enough RAM #1706

Merged
merged 3 commits into from
Jan 23, 2024
Merged

feat: error message when not enough RAM #1706

merged 3 commits into from
Jan 23, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Jan 22, 2024

Fixes Issues

Self Checklist

  • Updated docs (for bug fixes / features)

@urmauur urmauur self-assigned this Jan 22, 2024
@urmauur urmauur requested a review from louis-jan January 22, 2024 13:03
@urmauur urmauur added this to the v0.4.5 milestone Jan 22, 2024
@github-actions github-actions bot added the type: bug Something isn't working label Jan 22, 2024
@urmauur urmauur added type: feature request A new feature and removed type: bug Something isn't working labels Jan 22, 2024
@urmauur urmauur changed the title fix: error message when not enough RAM feat: error message when not enough RAM Jan 22, 2024
@urmauur urmauur requested a review from namchuai January 23, 2024 03:08
louis-jan
louis-jan approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit 7d511cf into dev Jan 23, 2024
7 checks passed
@urmauur urmauur deleted the fix/error-message branch January 23, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees

@urmauur urmauur

Labels
type: feature request A new feature
Projects
Menlo
Archived in project
Milestone
v0.4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@urmauur @louis-jan