Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto select text when collapse panel #1645

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix: auto select text when collapse panel #1645

merged 1 commit into from
Jan 17, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Jan 17, 2024

Describe Your Changes

  • Randomly auto select text when you double click icon for collapse panel

Fixes Issues

Screen.Recording.2024-01-17.at.14.25.30.mov

Self Checklist

  • Updated docs (for bug fixes / features)

@urmauur urmauur added the type: bug Something isn't working label Jan 17, 2024
@urmauur urmauur requested review from namchuai and louis-jan January 17, 2024 07:31
@urmauur urmauur self-assigned this Jan 17, 2024
@urmauur urmauur changed the title fix: auto text select when collapse panel fix: auto text selection when collapse panel Jan 17, 2024
@urmauur urmauur changed the title fix: auto text selection when collapse panel fix: auto select text when collapse panel Jan 17, 2024
@urmauur urmauur changed the base branch from main to dev January 17, 2024 07:32
@github-actions GitHub Actions
Copy link
Contributor

Preview URL: https://e70ef0d2.jan-qn8.pages.dev

louis-jan
louis-jan approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit fc025f6 into dev Jan 17, 2024
10 checks passed
@urmauur urmauur deleted the fix/auto-text-select-collapse-panel branch January 17, 2024 08:39
@urmauur urmauur added this to the v0.4.5 milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees

@urmauur urmauur

Labels
type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
v0.4.5
Development

Successfully merging this pull request may close these issues.

bug: random selection when I expand & collapse 2 panels
2 participants
@urmauur @louis-jan