fix: suppress all main node JS error message dialog #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-menlo
force-pushed
the
fix/suppress-main-node-uncaught-exception
branch
from
a7b5e06 to
9549c40
Compare
hiento09
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
As per user reports, there is still a case where the app could show a 'JavaScript error occurred in the main process' on quit. This pull request is intended to handle unhandled exceptions so that we can log them to the error log accordingly in #1430
Fixes Issues
fixes #1264
Self Checklist
Next Actions
Write unhandled error message into log file in #1430 for further user problem report.