Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NVIDIA monitoring #1407

Closed
wants to merge 19 commits into from
Closed

feat: NVIDIA monitoring #1407

wants to merge 19 commits into from

Conversation

hiro-v
Copy link
Contributor

@hiro-v hiro-v commented Jan 6, 2024 •
edited
Loading

Describe Your Changes

  • Monitor: NVIDIA total VRAM and current load (GPU and VRAM)

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed
  • web/containers/Layout/BottomBar/index.tsx only render when there is data
  • Test on Windows (1 GPU)
  • Test on Ubuntu (1 GPU)

Blockers

@hiro-v hiro-v added the P2: nice to have Nice to have feature label Jan 6, 2024
@hiro-v hiro-v self-assigned this Jan 6, 2024
@github-actions github-actions bot added the type: feature request A new feature label Jan 6, 2024
@hiro-v
Copy link
Contributor Author

hiro-v commented Jan 7, 2024 •
edited
Loading

Window with NVIDIA

  • No NVIDIA GPU
    CleanShot 2024-01-07 at 11 57 05

  • Idle
    CleanShot 2024-01-07 at 10 42 46

  • NVIDIA in use
    CleanShot 2024-01-07 at 11 37 37

@hiro-v hiro-v force-pushed the feat/extension_monitoring_nvidia branch from 6983f57 to 62bec27 Compare January 7, 2024 04:36
@hiro-v hiro-v requested a review from a team January 7, 2024 04:39
@hiro-v hiro-v force-pushed the feat/extension_monitoring_nvidia branch from c7d7f42 to 421a6d7 Compare January 7, 2024 09:20
@imtuyethan imtuyethan mentioned this pull request Jan 9, 2024
Closed
ritish78
ritish78 reviewed Jan 9, 2024
View reviewed changes
Copy link

@ritish78 ritish78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing gpu monitoring.

@pbeens
Copy link

pbeens commented Jan 10, 2024

Still not seeing it with last night's build (Jan v0.4.3-137) on my Windows PC with "NVidia GPU" (RTX-3060) enabled and working.

@hiro-v hiro-v force-pushed the feat/extension_monitoring_nvidia branch from 980cf0a to 34369c5 Compare January 16, 2024 04:06
@hiro-v hiro-v requested review from louis-menlo, hiento09 and namchuai and removed request for namchuai January 16, 2024 04:07
@louis-menlo louis-menlo changed the base branch from main to dev January 16, 2024 04:55
hiento09
hiento09 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hiro-v hiro-v force-pushed the feat/extension_monitoring_nvidia branch from 34369c5 to 4aef203 Compare January 22, 2024 04:03
@hiro-v hiro-v force-pushed the feat/extension_monitoring_nvidia branch from a752fff to b36eefb Compare January 22, 2024 04:20
@hiento09
Copy link
Collaborator

Close this PR, I implement gpu monitor in this PR #1730

@hiento09 hiento09 closed this Jan 24, 2024
@hiro-v hiro-v deleted the feat/extension_monitoring_nvidia branch January 30, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai left review comments

@ritish78 ritish78 ritish78 left review comments

@louis-menlo louis-menlo louis-menlo left review comments

@hiento09 hiento09 hiento09 approved these changes

Assignees

@hiro-v hiro-v

Labels
P2: nice to have Nice to have feature type: feature request A new feature
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hiro-v @pbeens @hiento09 @namchuai @ritish78 @louis-menlo