Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: darkmode broken color #1186

Merged
merged 1 commit into from
Dec 25, 2023
Merged

fix: darkmode broken color #1186

merged 1 commit into from
Dec 25, 2023

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Dec 25, 2023

fixes #1170

Description

Broken schema color when dark mode
Screenshot 2023-12-25 at 11 01 18

Scenario test

  • Set your device to light mode by setting
  • Go to app and make sure color schema dark mode works well
  • Try switch to light or dark via app, user should be smoothly change color schema

Screenshot

Screenshot 2023-12-25 at 11 02 26
Screen.Recording.2023-12-25.at.11.04.38.mov

@urmauur urmauur requested a review from louis-menlo December 25, 2023 04:16
@urmauur urmauur self-assigned this Dec 25, 2023
luiyen
luiyen approved these changes Dec 25, 2023
View reviewed changes
Copy link

@luiyen luiyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit dd0a18a into main Dec 25, 2023
7 checks passed
@urmauur urmauur deleted the fix/darkmode branch December 25, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-menlo louis-menlo louis-menlo approved these changes

@luiyen luiyen luiyen approved these changes

Assignees

@urmauur urmauur

Labels
type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: darkmode broken color
3 participants
@urmauur @luiyen @louis-menlo