Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: inference plugin should check service status before sending messages #247

Closed
louis-menlo opened this issue Oct 2, 2023 · 5 comments
Closed

chore: inference plugin should check service status before sending messages #247

louis-menlo opened this issue Oct 2, 2023 · 5 comments
Assignees
@louis-menlo
Labels
P1: important Important feature / fix type: enhancement Improves a current feature
Milestone
Jan v0.2.0

Comments

@louis-menlo
Copy link
Contributor

louis-menlo commented Oct 2, 2023 •
edited
Loading

  • For now the application does not know when Nitron is ready to use, it is risky to send request to the inference endpoint.
  • This service check will give a clue for an UX improvement (loading / error state...)
@louis-menlo louis-menlo added this to Menlo Oct 2, 2023
@louis-menlo louis-menlo converted this from a draft issue Oct 2, 2023
@louis-menlo louis-menlo self-assigned this Oct 2, 2023
@louis-menlo louis-menlo changed the title chore: inference plugin should check service status before allowing conversation to send message chore: inference plugin should check service status before sending messages Oct 2, 2023
@louis-menlo
Copy link
Contributor Author

cc @tikikun @vuonghoainam

@louis-menlo louis-menlo moved this from Todo to In Progress in Menlo Oct 4, 2023
@louis-menlo
Copy link
Contributor Author

Update:

  • Adding available port checking for verification, should emit error to UI if any

@freelerobot freelerobot added this to the Jan v0.1.4 milestone Oct 9, 2023
@freelerobot freelerobot added P1: important Important feature / fix type: enhancement Improves a current feature labels Oct 9, 2023
louis-menlo added a commit that referenced this issue Oct 9, 2023
@louis-menlo
fix: #247 - inference plugin should check nitro service available
2fa145b
louis-menlo added a commit that referenced this issue Oct 9, 2023
@louis-menlo
fix: #247 - inference plugin should check nitro service available
44051fb
louis-menlo added a commit that referenced this issue Oct 9, 2023
@louis-menlo
fix: #247 - inference plugin should check nitro service available
d6257e6
louis-menlo added a commit that referenced this issue Oct 10, 2023
@louis-menlo
fix: #247 check service status and emit error if any
99c71d0
@louis-menlo louis-menlo moved this from In Progress to In Review in Menlo Oct 10, 2023
@louis-menlo
Copy link
Contributor Author

Image
Image

@louis-menlo
Copy link
Contributor Author

Now user can see loading indicator when nitro is booting up. Also a timeout error (we would not try to catch the error from subprocess, it is quite messy for now and not a clean approach)

@louis-menlo
Copy link
Contributor Author

Image

hiento09 pushed a commit that referenced this issue Oct 10, 2023
@louis-menlo @hiento09
fix: #247 - inference plugin should check nitro service available
65b1095
hiento09 pushed a commit that referenced this issue Oct 10, 2023
@louis-menlo @hiento09
fix: #247 check service status and emit error if any
d7b2edf
@github-project-automation github-project-automation bot moved this from In Review to Done in Menlo Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louis-menlo louis-menlo

Labels
P1: important Important feature / fix type: enhancement Improves a current feature
Projects
Menlo
Archived in project
Milestone
Jan v0.2.0
Development

No branches or pull requests
2 participants
@freelerobot @louis-menlo