Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Correct text for Windows #1758

Closed
hahuyhoang411 opened this issue Jan 25, 2024 · 2 comments
Closed

bug: Correct text for Windows #1758

hahuyhoang411 opened this issue Jan 25, 2024 · 2 comments
Assignees
@namchuai @Van-QA
Labels
type: bug Something isn't working
Milestone
v0.4.6

Comments

@hahuyhoang411
Copy link
Contributor

Describe the bug
In Windows, we don't have Finder

Steps to reproduce
Steps to reproduce the behavior:

  1. Open App
  2. Click on the expand setting of Threads or Asisstant
  3. See error

Expected behavior
It should show Show in File Explorer

Screenshots
image

Environment details

  • Operating System: Win10
  • Jan Version: v0.4.4-171
@hahuyhoang411 hahuyhoang411 added the type: bug Something isn't working label Jan 25, 2024
@namchuai namchuai self-assigned this Jan 25, 2024
namchuai pushed a commit that referenced this issue Jan 25, 2024
fix(Wording): #1758 correct text for windows
dfe1ea9 
Signed-off-by: James <[email protected]>
@namchuai namchuai mentioned this issue Jan 25, 2024
Closed
3 tasks
namchuai pushed a commit that referenced this issue Jan 25, 2024
fix(Wording): #1758 correct text for windows
38cc0c4 
Signed-off-by: James <[email protected]>
@namchuai namchuai mentioned this issue Jan 25, 2024
Merged
3 tasks
namchuai added a commit that referenced this issue Jan 25, 2024
@namchuai
fix(Wording): #1758 correct text for windows (#1768)
acc774d 
Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
hiento09 pushed a commit that referenced this issue Jan 25, 2024
@namchuai @hiento09
fix(Wording): #1758 correct text for windows (#1768)
db0b714 
Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
@Van-QA Van-QA added this to the v0.4.6 milestone Jan 26, 2024
@namchuai namchuai moved this to In Review in Menlo Jan 29, 2024
@louis-jan louis-jan moved this from In Review to QA in Menlo Jan 29, 2024
@namchuai
Copy link
Collaborator

@Van-QA , please help to verify this issue. Thank you!

@Van-QA
Copy link
Contributor

Van-QA commented Jan 31, 2024

Tested and looking good on Jan v0.4.5-212 ✅

image

@Van-QA Van-QA closed this as completed Jan 31, 2024
@github-project-automation github-project-automation bot moved this from QA to Done in Menlo Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namchuai namchuai

@Van-QA Van-QA

Labels
type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
v0.4.6
Development

No branches or pull requests
3 participants
@namchuai @hahuyhoang411 @Van-QA