Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: investigate what's (purportedly) hogging resources #1650

Closed
freelerobot opened this issue Jan 17, 2024 · 4 comments
Closed

bug: investigate what's (purportedly) hogging resources #1650

freelerobot opened this issue Jan 17, 2024 · 4 comments
Assignees
Labels
P0: critical Mission critical type: bug Something isn't working
Milestone

Comments

@freelerobot
Copy link
Contributor

freelerobot commented Jan 17, 2024

Describe the bug
A clear and concise description of what the bug is.

A few reports of Jan v0.4.4 taking up compute and or ram.

Steps to reproduce
Steps to reproduce the behavior:

  1. Download and compare 0.4.3 vs 0.4.3

Expected behavior
A clear and concise description of what you expected to happen.

  1. Jan shouldn't actively use RAM & CPU when idle
  2. It could be that users are confusing System Monitor metrics to mean that "Jan is using 80% of my CPU/RAM"
  3. When, in fact, we're just measuring all RAM usage across all applications.

Regardless, let's treat this as a performance regression and investigate it as such.

Outcomes

  1. Diagnostic on what is consuming RAM
  2. Diagnostic on what is consuming CPU
  3. Overview of Jans main processes and % of utilization (when actively being used)
  4. A list of Jan processes that can improved (regardless if we are being a resource hog or not)

Screenshots
If applicable, add screenshots to help explain your issue.

Users may be confused and think this is Jan utilization, when in fact, it is all applications.
@imtuyethan 's new designs should partly address this:
image

Environment details

  • Assume all envs

Logs
N/A

Additional context
Add any other context or information that could be helpful in diagnosing the problem.

@freelerobot freelerobot added the type: bug Something isn't working label Jan 17, 2024
@freelerobot freelerobot added this to the v0.4.5 milestone Jan 18, 2024
@freelerobot freelerobot added the P0: critical Mission critical label Jan 18, 2024
@freelerobot freelerobot changed the title bug: investigate what's hogging resources bug: investigate what's (purportedly) hogging resources Jan 18, 2024
@hiento09 hiento09 moved this to In Progress in Menlo Jan 18, 2024
@hiento09
Copy link
Collaborator

This file https://github.com/janhq/jan/blob/main/extensions/inference-nitro-extension/src/module.ts, line 103 cause this bug, @0xSage , @Van-QA . The issue is described as follows: in version 0.4.4, the Nitro CPU utilizes all of the number of CPU cores for inference, resulting in 100% CPU usage. This leads to a lack of CPU resources for the Jan app to process other tasks, consequently slowing down the user's entire machine. To fix this issue, I will create a Pull Request (PR) to modify the CPU version to use only half of the CPU cores for running Nitro, instead of using all cores as it currently does

Image

hiento09 added a commit that referenced this issue Jan 18, 2024
hiento09 added a commit that referenced this issue Jan 18, 2024
hiento09 added a commit that referenced this issue Jan 18, 2024
hiento09 added a commit that referenced this issue Jan 18, 2024
hiento09 added a commit that referenced this issue Jan 18, 2024
hiento09 added a commit that referenced this issue Jan 18, 2024
@freelerobot
Copy link
Contributor Author

freelerobot commented Jan 19, 2024 via email

@freelerobot
Copy link
Contributor Author

@hiro-v you might wanna convert this into an epic to properly track all the follow ups in the Tasklist

@hiento09 hiento09 moved this from In Progress to Planned in Menlo Jan 22, 2024
@Van-QA Van-QA modified the milestones: v0.4.5, v0.4.6 Jan 22, 2024
@hiro-v
Copy link
Contributor

hiro-v commented Jan 23, 2024

Closing in favor of #1714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0: critical Mission critical type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants