Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: App caches model settings among threads #1065

Closed
Tracked by #1063
louis-menlo opened this issue Dec 18, 2023 · 2 comments · Fixed by #1090
Closed
Tracked by #1063

bug: App caches model settings among threads #1065

louis-menlo opened this issue Dec 18, 2023 · 2 comments · Fixed by #1090
Assignees
@namchuai
Labels
P0: critical Mission critical type: bug Something isn't working

Comments

@louis-menlo
Copy link
Contributor

Describe the bug
App caches modified model settings to all threads.

To Reproduce
Steps to reproduce the behavior:

  1. Switch off stream option in thread 1
  2. Send message, its not streamed ✅
  3. Go to thread 2 (which is enabled streaming)
  4. Toggle is not on ❌
  5. Send message, message is streaming ✅

Expected behavior
App should behave the same as the UI

Screenshots

record.mov
@louis-menlo louis-menlo added the type: bug Something isn't working label Dec 18, 2023
@louis-menlo louis-menlo mentioned this issue Dec 18, 2023
Closed
79 tasks
@louis-menlo louis-menlo added the P0: critical Mission critical label Dec 18, 2023
@freelerobot freelerobot moved this to Triaged (Backlog) in Menlo Dec 19, 2023
@freelerobot freelerobot moved this from Triaged (Backlog) to Todo in Menlo Dec 19, 2023
@namchuai
Copy link
Collaborator

Hmm, somehow I can't reproduce this issue.

Screen.Recording.2023-12-19.at.11.02.08.mov

@louis-menlo
Copy link
Contributor Author

Reproduced tgt

namchuai pushed a commit that referenced this issue Dec 19, 2023
feat(ModelSetting): #1065 update state of model setting between threads
9811821 
Signed-off-by: James <[email protected]>
@namchuai namchuai mentioned this issue Dec 19, 2023
Merged
namchuai added a commit that referenced this issue Dec 19, 2023
@namchuai
feat(ModelSetting): #1065 update state of model setting between threa…
7a148ea 
…ds (#1090)

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
@github-project-automation github-project-automation bot moved this from Planned to Done in Menlo Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namchuai namchuai

Labels
P0: critical Mission critical type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ModelSetting): #1065 update state of model setting between threads janhq/jan
2 participants
@namchuai @louis-menlo