Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix new thread default model logic to prefer active models #1043

Closed
Tracked by #1063
freelerobot opened this issue Dec 16, 2023 · 0 comments · Fixed by #1070
Closed
Tracked by #1063

bug: fix new thread default model logic to prefer active models #1043

freelerobot opened this issue Dec 16, 2023 · 0 comments · Fixed by #1070
Assignees
@namchuai
Labels
P0: critical Mission critical type: bug Something isn't working

Comments

@freelerobot
Copy link
Contributor

freelerobot commented Dec 16, 2023 •
edited
Loading

Describe the bug
Starting a new thread always defaults to Trinity (the first model in my model list).

Export-1702739361537

To Reproduce
Steps to reproduce the behavior:

  1. Start any model that's not Trinity, e.g. mistral
  2. Chat
  3. Create a new thread
  4. Thread Model defaults to Trinity
  5. Select a different model
  6. Go to another thread
  7. Return to thread
  8. Model is trinity again

Expected behavior
A clear and concise description of what you expected to happen.

Here's what I expect New Thread model dropdown to default to:

  • Empty state: No models downloaded
  1. Active model
  2. If no active model(s), then the last used model
  3. If no active or last used model, then the 1st model on the list

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: mac os m1
  • Version: 0.4.2

Additional context
Add any other context about the problem here.
@freelerobot freelerobot added P0: critical Mission critical type: bug Something isn't working labels Dec 16, 2023
@freelerobot freelerobot changed the title bug: why do all new threads default to Trinity?! bug: why do all new threads default to Trinity? Dec 16, 2023
@freelerobot freelerobot changed the title bug: why do all new threads default to Trinity? bug: all new threads default to Trinity Dec 16, 2023
@freelerobot freelerobot changed the title bug: all new threads default to Trinity bug: all threads default to Trinity Dec 16, 2023
@freelerobot freelerobot modified the milestones: Jan December Launch, Jan as the Default Assistant Dec 18, 2023
@freelerobot freelerobot changed the title bug: all threads default to Trinity bug: fix new thread default model logic to prefer active models Dec 18, 2023
@freelerobot freelerobot moved this to Todo in Menlo Dec 18, 2023
@freelerobot freelerobot mentioned this issue Dec 18, 2023
Closed
@namchuai namchuai assigned namchuai and unassigned louis-menlo Dec 18, 2023
@louis-menlo louis-menlo mentioned this issue Dec 18, 2023
Closed
79 tasks
namchuai pushed a commit that referenced this issue Dec 18, 2023
fix(thread): #1043 default model to prefer active model
6986ed3 
Signed-off-by: James <[email protected]>
namchuai pushed a commit that referenced this issue Dec 18, 2023
fix(thread): #1043 default model to prefer active model
d084975 
Signed-off-by: James <[email protected]>
@namchuai namchuai mentioned this issue Dec 18, 2023
Merged
namchuai pushed a commit that referenced this issue Dec 18, 2023
fix(thread): #1043 default model to prefer active model
5faa811 
Signed-off-by: James <[email protected]>
namchuai pushed a commit that referenced this issue Dec 19, 2023
fix(thread): #1043 default model to prefer active model
afe2cd0 
Signed-off-by: James <[email protected]>
namchuai added a commit that referenced this issue Dec 19, 2023
@namchuai
fix(thread): #1043 default model to prefer active model (#1070)
55ab4ae 
Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in Menlo Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namchuai namchuai

Labels
P0: critical Mission critical type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(thread): #1043 default model to prefer active model janhq/jan
3 participants
@namchuai @freelerobot @louis-menlo