Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: "Use Model" from the Hub fails to launch full Threads screen with Right Panel #1042

Closed
Tracked by #1063
dan-menlo opened this issue Dec 15, 2023 · 3 comments · Fixed by #1103
Closed
Tracked by #1063

bug: "Use Model" from the Hub fails to launch full Threads screen with Right Panel #1042

dan-menlo opened this issue Dec 15, 2023 · 3 comments · Fixed by #1103
Assignees
@namchuai
Labels
P1: important Important feature / fix type: bug Something isn't working

Comments

@dan-menlo
Copy link
Contributor

dan-menlo commented Dec 15, 2023 •
edited
Loading

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Hub
  2. Click "Use" for an already Downloaded model
  3. Jan goes to a zombie "Threads" screen where unable to type in Input box, no Right Panel

Screenshots

Click "Use" for a downloaded model
image

Zombie screen (unable to type in Input box, no Right Panel)
image

Desktop (please complete the following information):

  • OS: Ubuntu 22.04
  • 16gb RAM, no GPU

Additional context
Add any other context about the problem here.
@dan-menlo dan-menlo added the type: bug Something isn't working label Dec 15, 2023
@freelerobot
Copy link
Contributor

I'm experiencing a variation of this issue.

To repro:

  1. Click on use model (not currently active) in the Hub
  2. It takes me to a previous thread, while starting the model
image 3. The problem is that the UI shows the new model in the previous thread.

I expected:

  1. Click on use
  2. Land in a NEW thread
  3. Wait for model to start.

Should be a simple fix hopefully

@freelerobot freelerobot moved this to Todo in Menlo Dec 18, 2023
@louis-jan louis-jan assigned urmauur and unassigned louis-jan Dec 18, 2023
@louis-jan louis-jan mentioned this issue Dec 18, 2023
Closed
79 tasks
@urmauur urmauur moved this from Todo to In Progress in Menlo Dec 19, 2023
@louis-jan louis-jan assigned namchuai and unassigned urmauur Dec 19, 2023
@louis-jan
Copy link
Contributor

@namchuai: spawn new thread

@louis-jan louis-jan added the P1: important Important feature / fix label Dec 19, 2023
namchuai pushed a commit that referenced this issue Dec 19, 2023
fix(Thread): #1042 allow create new thread by clicking Use in Jan Hub
5bb8324 
Signed-off-by: James <[email protected]>
@namchuai namchuai mentioned this issue Dec 19, 2023
Merged
@namchuai
Copy link
Collaborator

created a PR #1103

Not really a bug since it's not being implemented. Definitely not a simple fix lol

@github-project-automation github-project-automation bot moved this from In Progress to Done in Menlo Dec 19, 2023
namchuai added a commit that referenced this issue Dec 19, 2023
@namchuai
fix(Thread): #1042 allow create new thread by clicking Use in Jan Hub (…
84fb5ef 
…#1103)

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namchuai namchuai

Labels
P1: important Important feature / fix type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Thread): #1042 allow create new thread by clicking Use in Jan Hub janhq/jan
5 participants
@urmauur @namchuai @freelerobot @dan-menlo @louis-jan