Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debian version for Dockerfiles #853

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

paulgb
Copy link
Member

@paulgb paulgb commented Dec 10, 2024

No description provided.

@paulgb paulgb requested a review from jakelazaroff December 10, 2024 19:05
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plane ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 7:05pm

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c841ab1 in 3 seconds

More details
  • Looked at 24 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docker/Dockerfile:1
  • Draft comment:
    Changing the base image from 'bullseye' to 'bookworm' is a major version change. Ensure all dependencies and the application are compatible with 'bookworm'. This applies to both Dockerfiles.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the base image from 'bullseye' to 'bookworm'. This is a major version change in Debian, which could introduce compatibility issues. It's important to ensure that all dependencies and the application itself are compatible with the new base image.

Workflow ID: wflow_Gigrc7gFGff6PX6Z


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paulgb paulgb merged commit 1c9b421 into main Dec 10, 2024
8 checks passed
@paulgb paulgb deleted the paulgb/fix-debian-version branch December 10, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants