add db cli command for marking a drones backends as lost #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 323d1e1 in 1 minute and 25 seconds
More details
- Looked at
253lines of code in5files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. plane/src/drone/executor.rs:235
- Draft comment:
Theterminatefunction no longer returns aResult, so the?operator should be removed from this call. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_rvawqvQG4Ri2vc2V
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rolyatmax
force-pushed
the
taylor/dis-2961-plane-add-db-cli-command-for-marking-a-drones-backends-as
branch
from
323d1e1 to
ae23dfa
Compare
paulgb
approved these changes
Nov 22, 2024
rolyatmax
deleted the
taylor/dis-2961-plane-add-db-cli-command-for-marking-a-drones-backends-as
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.