[pull] master from chromium:master #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Bug: 1240645 Change-Id: If5fe54e65f8235c92b5d4d380d0fe3df80ce7522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197701 Reviewed-by: Mike Wittman <[email protected]> Commit-Queue: Erik Chen <[email protected]> Cr-Commit-Position: refs/heads/main@{#927268}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633089497-e8cfd19b9c37dcfc995323a07984860afb9e9271.profdata to chrome-win64-main-1633100354-2e6443e43e22e09dc2ebc5467e0536890c7509e5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: [email protected] Change-Id: I0ebc54f6ce947b6b960d98b80e4bafaed8505684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200094 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#927269}
This CL implements the delegate method to be used by Enterprise Connectors content scanning to allow/block a save package. The implementation of that method is in crrev.com/c/3160844. See bug for design doc. Bug: 1248459 Change-Id: If4743565373f1b5d62a9dd5471800a4a2bb8036c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152736 Reviewed-by: Nasko Oskov <[email protected]> Reviewed-by: Min Qin <[email protected]> Commit-Queue: Dominique Fauteux-Chapleau <[email protected]> Cr-Commit-Position: refs/heads/main@{#927270}
crrev.com/c/3191116 removed a file that defined a traffic annotation.
Because of what looks like a bug in the Auditor (it ignores file
deletions?...), this bypassed annotations.xml validation.
Fix the entry in annotations.xml to make {linux,win}-annotator-rel
green again.
Bug: 1255109
Change-Id: If5f890263d57b7d07d18327c395afff0d9d6d228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199573
Commit-Queue: Nicolas Ouellet-Payeur <[email protected]>
Reviewed-by: Igor Ruvinov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#927271}
Bug: 1234532 Change-Id: Ie94d99bb78d81bf2dcc3f42de3d11d4b64c48cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198895 Commit-Queue: Evan Bernstein <[email protected]> Reviewed-by: Sylvain Defresne <[email protected]> Cr-Commit-Position: refs/heads/main@{#927272}
These changes are to speed up benchmarks on low end ARM while making all tests enabled by default https://chromium.googlesource.com/libyuv/libyuv.git/+log/b92a60320f6d..d13d9d5972ec $ git log b92a60320..d13d9d597 --date=short --no-merges --format='%ad %ae %s' 2021-09-29 fbarchard Disable slow and redundant scaling tests 2021-09-27 fbarchard DISABLE_SLOW_TESTS replaces ENABLE_SLOW_TESTS 2021-09-24 fbarchard Prune conversion tests to OPT and I420 variations 2021-09-23 fbarchard Scale Test3x, Test4x use larger size to avoid div benchmarking bottleneck Created with: roll-dep src/third_party/libyuv Bug: b/197551385 Change-Id: I984c82cfbcf1a5913c11845e0a13ab0cdc7ba954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198857 Commit-Queue: Frank Barchard <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Cr-Commit-Position: refs/heads/main@{#927273}
This reverts commit 90807f9. Reason for revert: Now that Sylvain's fix has landed, reverting is probably cleanest to get webrtc back on xc12 124de. Anything newer than that requires Mac11. Original change's description: > Moves the WebRTC iOS bots to use x13main. > > These bots are building //ios/chrome, so they need to be on the same > version of Xcode as the main Chromium iOS bots in order to meet our > minimum Xcode requirements. > > Bug: webrtc:13221 > Change-Id: I7d850d65794d758a4acc925c575164f84c2f740e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193175 > Reviewed-by: Mirko Bonadei <[email protected]> > Commit-Queue: Rohit Rao <[email protected]> > Cr-Commit-Position: refs/heads/main@{#926710} Bug: webrtc:13221 Change-Id: I4660c420d5a689766008752d5a802b3fa5e3ea5f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198732 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Sylvain Defresne <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Commit-Queue: Lindsay Pasricha <[email protected]> Cr-Commit-Position: refs/heads/main@{#927274}
AndroidX autoroller has broken because we are using classic desugar. I ran the CrashesListFragmentTest, which was mentioned as an example why this was done, and the tests passed locally. Change-Id: I460d141287f09accb6a174502b6e94a685f5a414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198138 Reviewed-by: Peter Wen <[email protected]> Commit-Queue: Sam Maier <[email protected]> Auto-Submit: Sam Maier <[email protected]> Cr-Commit-Position: refs/heads/main@{#927275}
BluetoothSocketMac::Receive ignores the buffer_size parameter, and there is no sanity-check to make sure the data received from the BluetoothSocket fits in our in_stream_ buffer, so this change will allow a single write to be broken up into multiple instances of sending data. This can also be tested with the "large writes" manual test in serialPort_loopback-manual.https.html. This is a continuation of crrev.com/c/2402127 started by [email protected]. Bug: 1043300 Change-Id: I0e72d78b9e73a45945e11849419b2f8fcb1bf251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3176310 Commit-Queue: Chris Mumford <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Cr-Commit-Position: refs/heads/main@{#927276}
Take into account changes on highlight pseudos (::target-text, ::spelling-error and ::grammar-error) in order to compute StyleDifference in LayoutObject::SetStyle(). 002 tests fail due to a problem that is being fixed in CL:3197850. Apart from that target-text tests fail due to a repainting issue (see https://crbug.com/1179938). BUG=1035708,1251193 TEST=external/wpt/css/css-pseudo/target-text-dynamic-00*.html TEST=wpt_internal/css/css-pseudo/grammar-error-color-dynamic-00*.html TEST=wpt_internal/css/css-pseudo/spelling-error-color-dynamic-00*.html Change-Id: I83ab02ab1225df86fbb9251eb0954409c17f9843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177663 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Reviewed-by: Delan Azabani <[email protected]> Commit-Queue: Manuel Rego <[email protected]> Cr-Commit-Position: refs/heads/main@{#927277}
This appears to have been added for the app protocol registration work in crrev.com/c/2644243, called from AddAppProtocolClients, which no longer exists, removed in crrev.com/c/2830297 Change-Id: I9fb72ffd80879f1f137d9584879cae157776ee79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199972 Reviewed-by: Jesse McKenna <[email protected]> Commit-Queue: David Bienvenu <[email protected]> Cr-Commit-Position: refs/heads/main@{#927278}
This reverts commit 846c90a. Reason for revert: testInstantStartDisabledOnLowEndDevice is still flaky. Sample failing test run: https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/6303 Original change's description: > Renable InstantStartTest#testInstantStartDisabledOnLowEndDevice > > Renable the test due to the fix CL has landed: > https://chromium-review.googlesource.com/c/chromium/src/+/3189322 > > Bug: 1254327 > Change-Id: I29b2d6a84d6a97810f50d6ba9eba86d94a7a2eed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3196850 > Reviewed-by: Sky Malice <[email protected]> > Commit-Queue: Xi Han <[email protected]> > Cr-Commit-Position: refs/heads/main@{#926792} Bug: 1254327 Change-Id: I75e460db8e817391ad36315fd0ff143a1479a041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199054 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Sky Malice <[email protected]> Reviewed-by: Xi Han <[email protected]> Commit-Queue: Xi Han <[email protected]> Cr-Commit-Position: refs/heads/main@{#927279}
This CL adds kDownloadVcard flag and creates the entry point for the following CLs. Bug: 1244002 Change-Id: I03669ee1380d1af3cb81b52c49a54387dab9ed7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195916 Reviewed-by: Gauthier Ambard <[email protected]> Commit-Queue: Ewann Pellé <[email protected]> Cr-Commit-Position: refs/heads/main@{#927280}
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202110010800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/WIl-ktdiCSDSuXu07BcO1xjrviSDTmGkWQ7cKMP-5fcC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: [email protected] Change-Id: Id44743dbe4c2d02d632a44a8759752995bd31979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198626 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927281}
Floss does not yet support this, so simply do no-op when requested to avoid crash. Bug: b:201701784 Change-Id: Ica70c0e1e51800788b643e53dede1c72cd923eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198799 Reviewed-by: Kyle Horimoto <[email protected]> Commit-Queue: Sonny Sasaka <[email protected]> Cr-Commit-Position: refs/heads/main@{#927282}
FDE2 is registered to Google while FFF9 is registered to FIDO. Since we want caBLEv2 to be used by more than just Google, switch to the latter UUID. Chrome desktop has accepted either since M93, thus Android >= 96 won't be able to do caBLE with Chrome < 93. Around Chrome 99 we'll drop support for recognising FDE2. BUG=1002262 Change-Id: Iad83b09da243b2e2ff8def8c3b3fd2e7063ffa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197837 Auto-Submit: Adam Langley <[email protected]> Commit-Queue: Martin Kreichgauer <[email protected]> Reviewed-by: Martin Kreichgauer <[email protected]> Cr-Commit-Position: refs/heads/main@{#927283}
Roll Chrome Win32 PGO profile from chrome-win32-main-1633089497-4be84ee872c58c90115cdb68aa80d15b279481e9.profdata to chrome-win32-main-1633100354-28c73e357a900b658117e17f2215682c7a8fabb2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: [email protected] Change-Id: I62f2d5ec94fa9b4d6b0296c8fd0456012e04b57d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199605 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#927284}
Change-Id: I3bf60c56032d551ed5c3568d6cdf73212cd3d0ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200110 Auto-Submit: Caleb Raitto <[email protected]> Reviewed-by: Matt Menke <[email protected]> Commit-Queue: Matt Menke <[email protected]> Cr-Commit-Position: refs/heads/main@{#927285}
https://android.googlesource.com/platform/external/perfetto.git/+log/c10e58491f2a..db4c45987622 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Idf3d3efb0fda4be90264e9109849d9530e4f5cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199322 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#927286}
This is a follow-on change to crrev.com/c/3048161. That CL splits the Document::execCommand signature in two. This change renames the string version to execCommandForTesting, to prevent inadvertent usage (and thus circumventing the security checks). Bug: 1230567 Change-Id: If74b27b239e192dd588f162b43751725f959c886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197150 Commit-Queue: Daniel Vogelheim <[email protected]> Reviewed-by: Mike West <[email protected]> Reviewed-by: Xiaocheng Hu <[email protected]> Reviewed-by: Yoshifumi Inoue <[email protected]> Cr-Commit-Position: refs/heads/main@{#927287}
The documentation says that hyphens, ampersands and commas should be escaped https://wicg.github.io/scroll-to-text-fragment/#:~:text=The%20text%20parameters%20are%20percent-decoded%20before%20matching.%20Dash%20(-)%2C%20ampersand%20(%26)%2C%20and%20comma%20(%2C)%20characters%20in%20text%20parameters%20must%20be%20percent-encoded%20to%20avoid%20being%20interpreted%20as%20part%20of%20the%20text%20directive%20syntax. but when using standard url encoding hyphen is not escaped. Bug: 1245669 Change-Id: Ie9bcefdf75bd302d219fda7137ca7de866164d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197798 Reviewed-by: David Bokan <[email protected]> Commit-Queue: Gayane Petrosyan <[email protected]> Cr-Commit-Position: refs/heads/main@{#927288}
While cleaning up usage of vulkan.h it was discovered that SkVulkanConfig.h is unused so this change deletes it. Bug: 1221278 Change-Id: If2d35d7bb4dcbdf57c09950ff0f85aca940f3bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198308 Reviewed-by: Brian Salomon <[email protected]> Commit-Queue: Bruce Dawson <[email protected]> Cr-Commit-Position: refs/heads/main@{#927289}
- Add skeleton js and html files. - Updates required build and grd file. - Tests component can be added to DOM. --gtest_filter=DiagnosticsApp* Bug: 1197335 Test: testing/xvfb.py out/Default/browser_tests Change-Id: I4eb40a51eec4a9cf8b3fae81a813c7af0c7924ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3191110 Commit-Queue: Zentaro Kavanagh <[email protected]> Reviewed-by: Zentaro Kavanagh <[email protected]> Cr-Commit-Position: refs/heads/main@{#927290}
Note that this overrides colors defined in: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/settings/settings_shared_css.html Before off (dark): http://shortn/_XQejbBJV1W After off (dark): http://shortn/_LfrHb3X3LP Before on (dark): http://shortn/_ABK9FunLro After on (dark): http://shortn/_Gl75gAXsg3 Before off (light): http://shortn/_o23AxxOfwq After off (light): http://shortn/_ZGhD3il3ZA Before on (light): http://shortn/_eCHSaQJTlz After on (light): http://shortn/_RBFQj165FG Bug: 1254873 Change-Id: I98d060e68a937ef6b19f672f3b3c44513fcec1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197844 Reviewed-by: Kyle Horimoto <[email protected]> Commit-Queue: David Black <[email protected]> Cr-Commit-Position: refs/heads/main@{#927291}
To CanRunWhenVirtualTimePausedTaskQueueTraits. The name is misleading since it doesn't actually avoids virtual time, it's equivalent to SetCanRunWhenVirtualTimePaused(). SetCanRunWhenVirtualTimePaused was renamed itself the same way here: https://chromium-review.googlesource.com/c/chromium/src/+/1792031 Change-Id: Ia826e01573782b7080918f8e7fd9f220b2535801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199534 Reviewed-by: Sami Kyöstilä <[email protected]> Reviewed-by: Alexander Timin <[email protected]> Commit-Queue: Etienne Pierre-Doray <[email protected]> Cr-Commit-Position: refs/heads/main@{#927292}
Some Chromecast browser tests produce a lot of output, so we'd like to be able to increase the output limit for those tests. Bug: internal b/199334531 Change-Id: I7fdc3dbbc841ecdd697f6bf19937b8da882aafce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198333 Commit-Queue: Kenneth MacKay <[email protected]> Reviewed-by: Gabriel Charette <[email protected]> Cr-Commit-Position: refs/heads/main@{#927293}
Each extension's manifest version is included in the extension info report sent to the DMServer. This change is implemented behind a feature flag which will be removed once server-side work is complete. Bug: 1204508, b/201559564 Change-Id: I240c091ed317400a449e72d9212aaf7d8a1a493c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197990 Reviewed-by: Owen Min <[email protected]> Commit-Queue: Igor Ruvinov <[email protected]> Cr-Commit-Position: refs/heads/main@{#927294}
These aren't suitable for auto-conversion because they require more than
a simple rename:
* base::Milliseconds() is a templated function, so taking its address
requires choosing a template overload
* The template machinery can't infer that CheckedNumeric types can
implicitly convert to integral values, so some explicit int64_t{}s are
required
Bug: 1243777
Change-Id: I3178679207ba2c914bdc22766cb9c2d2f41af110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198863
Owners-Override: Peter Kasting <[email protected]>
Auto-Submit: Peter Kasting <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#927295}
Adds the skeleton of the native and Java conversion bridges for the new ReactionMetadata class. For now the bridges aren't used and they are not very useful because the feature will never convert reaction metadata objects individually. Bug: 1253535 Change-Id: I6a679eb85bc55f49dbbee5c3a4e3d8f17565a4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197458 Commit-Queue: Guillaume Jenkins <[email protected]> Reviewed-by: Sophey <[email protected]> Reviewed-by: sebsg <[email protected]> Cr-Commit-Position: refs/heads/main@{#927296}
This patch stores the StyleRecalcChange from blocked style walks and accumulates that, instead of setting custom dirty bits, since that is bug prone (e.g. we can miss some new dirty bits). This also simplifies the code quite a bit. [email protected], [email protected] Bug: 1202618 Change-Id: Idc8d67ba746c018dc80db44152977cc5540932af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198134 Commit-Queue: vmpstr <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#927297}
Change-Id: I69f85d28f17111a06fdf806cdaeac200139b307a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199337 Auto-Submit: Shane Fitzpatrick <[email protected]> Reviewed-by: Jon Mann <[email protected]> Commit-Queue: Jon Mann <[email protected]> Cr-Commit-Position: refs/heads/main@{#927491}
This change improves performance of the omnibox by dropping the use of the RoundedBitmapDrawables. Bug: 1244097 Change-Id: If11d447eb45c0977422347878dde6b0ddfd90110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183396 Commit-Queue: Tomasz Wiszkowski <[email protected]> Reviewed-by: Theresa <[email protected]> Reviewed-by: Filip Gorski <[email protected]> Reviewed-by: Cathy Li <[email protected]> Cr-Commit-Position: refs/heads/main@{#927492}
This CL is to add the complete views for the Starting OTP Input State and the Pending State of the Card Unmask OTP Input dialog. This CL is a no-op, it does not contain any triggering logic so it will not alter current autofill functionality. Follow up CL's will introduce the incorrect OTP input error state. Default Theme: Starting OTP Input State: https://screenshot.googleplex.com/9PFhTCHMsLokK4Y Pending State: https://screenshot.googleplex.com/95My6usM549CESc Dark Theme: Starting OTP Input State: https://screenshot.googleplex.com/4NZPtPVNRy2hA8z Pending State: https://screenshot.googleplex.com/BKdANcq7UskZA8d Design Mocks: Starting OTP Input State: https://screenshot.googleplex.com/8gdhdCyyeuhWg2f Pending State: https://screenshot.googleplex.com/8KM7BaqqahpEa5v The screenshots will also be added to the Bug for public view. Change-Id: I56c510f202aac682c9669a294aba808f1d423300 Bug: 1243475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3187534 Commit-Queue: Vinny Persky <[email protected]> Reviewed-by: Mohamed Amir Yosef <[email protected]> Reviewed-by: Siyu An <[email protected]> Reviewed-by: Jared Saul <[email protected]> Cr-Commit-Position: refs/heads/main@{#927493}
Bug: 1255260 Change-Id: I2ceac202105b7d3fdfcff0bcad411109861f49a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199058 Reviewed-by: Michael Crouse <[email protected]> Commit-Queue: Sophie Chang <[email protected]> Cr-Commit-Position: refs/heads/main@{#927494}
These were some misc easy classes to move. Bug: 1254437 Change-Id: I4ec8971fafed28db5907c4574bb646ab5229ce84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197690 Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]> Reviewed-by: Jian Li <[email protected]> Reviewed-by: Peter Wen <[email protected]> Reviewed-by: Theresa <[email protected]> Commit-Queue: Dan H <[email protected]> Cr-Commit-Position: refs/heads/main@{#927495}
Actions were queried all the time on the assumption that SafeMode status isn't triggered for nonembedded actions but it isn't currently the case. SafeModeService doesn't distinguish between different types of actions and just enable SafeMode globally whenever it SafeMode is set. Handling different kind of actions differently would be a bigger change so embracing the status-quo ComponentUpdater services will now check the SafeMode status first before querying SafeMode actions. This way ComponentUpdater will just query SafeModeContentProvider only when SafeMode is enabled (which should be rare) reducing the likelihood of running into situations similar to crbug.com/1250801. However, this will still crash with an NPE until we solve crbug.com/1252783. Bug: 1252784 Test: run existing instrumentation tests Change-Id: Idd2fc8c6246fce661ba73c3d0f1a9bbecbef9ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197727 Reviewed-by: Nate Fischer <[email protected]> Commit-Queue: Hazem Ashmawy <[email protected]> Cr-Commit-Position: refs/heads/main@{#927496}
Bug: 1254717 Change-Id: I24860a0cce10c34f6801fb9c138451dc2c92613d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197151 Auto-Submit: Wez <[email protected]> Commit-Queue: Erik Staab <[email protected]> Reviewed-by: Robert Sesek <[email protected]> Reviewed-by: David Dorwin <[email protected]> Reviewed-by: Erik Staab <[email protected]> Cr-Commit-Position: refs/heads/main@{#927497}
Roll Chrome Mac PGO profile from chrome-mac-main-1633111074-9cc73b4c126b9ed2f8767b1172f4350cfce8ef23.profdata to chrome-mac-main-1633132768-6bbc5026cb2ca0c8db37db1f4c3f150ec56623ca.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: [email protected] Change-Id: Ieb49a3e4c73c377ac1e3b71392eefc58ea859f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200691 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#927498}
No change to logic. This fixes an issue introduced in https://crrev.com/c/3065476. That CL converted all python2 print statements to use parentheses, however `print()` will literally print `()` (it's a print statement with an empty tuple as an argument). As a quick fix, import the actual print_function to get the correct behavior. This will have no effect on python3 since the print function is builtin. Bug: 1223892 Test: third_party/android_platform/development/scripts/stack --help Change-Id: I1e2e7eb58c77b7ab4449e28932ff05a9b3598a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200060 Commit-Queue: Andrew Grieve <[email protected]> Auto-Submit: Nate Fischer <[email protected]> Reviewed-by: Andrew Grieve <[email protected]> Cr-Commit-Position: refs/heads/main@{#927499}
Roll Chrome Linux PGO profile from chrome-linux-main-1633111074-5ffd049107e232b21d39fca263418a89eae5f7f0.profdata to chrome-linux-main-1633132768-5649f11bdc1f3b7af2389dc767d257c2dffbff72.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: [email protected] Change-Id: I2faadc8a22ce6f4ec73400651c99cdae3907d868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200576 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#927500}
Some WMs get confused when frame hints are set on decorated windows, so this CL removes those hints when they're not needed. Bug: 1251382 Change-Id: I5a74db36c9fe07549d314f6f8561df27e7a0a214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199110 Commit-Queue: Thomas Anderson <[email protected]> Auto-Submit: Thomas Anderson <[email protected]> Reviewed-by: Scott Violet <[email protected]> Cr-Commit-Position: refs/heads/main@{#927501}
Add label inside the expand button for total notifications in a collapsed grouped notification. Update chevron for collapse/expand icon to match UX specs. Remove collapsed count view since it was removed from specs. Bug: 1233701 Change-Id: I5e354dca29ba2412c50d1295b2d5a43f1ee02f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200278 Commit-Queue: Ahmed Mehfooz <[email protected]> Reviewed-by: Alex Newcomer <[email protected]> Cr-Commit-Position: refs/heads/main@{#927502}
This reverts commit 7720169. Reason for revert: After looking more, the observer isn't the right pattern, as we only want to alert one of the read handlers. Original change's description: > desk_templates: Allow launching ARC apps p3. > > Adds AppRestoreArcInfo class to observe and notify ARC related changes. > Right now these events are going through FullRestoreUtils directly to > FullRestoreSaveHandler and FullRestoreReadHandler. We want another one > or two observers for desks templates in the future, so switch to a > more scalable pattern. > > Test: trybots > Bug: 1251403 > Change-Id: Ib6867bf2975d54c6bcc077034dd8941adb1c123f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3188749 > Commit-Queue: Sammie Quon <[email protected]> > Reviewed-by: Nancy Wang <[email protected]> > Cr-Commit-Position: refs/heads/main@{#926106} Bug: 1251403 Change-Id: I7b9a8594f91c0f111c558995392a7b9720d2b4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200391 Reviewed-by: Nancy Wang <[email protected]> Commit-Queue: Nancy Wang <[email protected]> Auto-Submit: Sammie Quon <[email protected]> Cr-Commit-Position: refs/heads/main@{#927503}
The check really pertains to the origin, not the entire URL. It also allows for a merging of logic between IsPdfExtensionOrigin() and IsPdfInternalPluginAllowedOrigin(). Furthermore, it makes the function more appropriate for security checks. Use IsPdfInternalPluginAllowedOrigin() in the implementation of ChromePrintRenderFrameHelperDelegate::GetPdfElement(). Change-Id: Ia8a6bb99a9e2d19b8bc857525ac74ac93e29c565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200416 Commit-Queue: Daniel Hosseinian <[email protected]> Reviewed-by: Lei Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#927504}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633121819-dd73c1ce595c11b56b5db14996ec5e95562e3932.profdata to chrome-win64-main-1633132768-497212cbbc78fb6edc1a70ea400e1928176bbc51.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: [email protected] Change-Id: I9f8166016ce543e16bb55c34fab5a86333a2bbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200730 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#927505}
Roll Chrome Win32 PGO profile from chrome-win32-main-1633121819-ac8d2e110b5f110fc1abb098defaf58b3da794e2.profdata to chrome-win32-main-1633132768-d60c7c3a852d8f49e24835984251bb0375d2e912.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: [email protected] Change-Id: I14bc77b9c814c07e643a07a1ded1980ef09b26be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200731 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#927506}
Adds labels for the top gamepads recorded on the Gamepad.KnownGamepadConnectedWithId histogram. Vendor names are based on the names in the Valid USB Vendor IDs list available at https://www.usb.org/developers Some existing GamepadId enums are renamed to match the new GamepadVendorProduct label. A tool for generating these labels will be added in a separate CL. Bug: None Change-Id: I1b204af7a9a7184f62b5e6a8a76b80894345db2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3159255 Commit-Queue: Matt Reynolds <[email protected]> Reviewed-by: Chris Mumford <[email protected]> Cr-Commit-Position: refs/heads/main@{#927507}
This CL fixes a flakey test that was caused by a rogue popstate event that looks like it is caused by the test setup. This popstate event caused the cr-dialog to close unintentionally. Adding flushAsync prevented the popstate event from happening during this test. The popstate event has a pathname of /test_loader.html. Confirmed the fix by running the test 500 times. Fixed: 1248603 Change-Id: Ie669eb44a6575fd640e46c47736432cd3a9fecf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200351 Reviewed-by: Kyle Horimoto <[email protected]> Reviewed-by: Jon Mann <[email protected]> Commit-Queue: Claude van der Merwe <[email protected]> Cr-Commit-Position: refs/heads/main@{#927508}
Removes constants used for apps container layout from AppListConfig. This leaves AppListConfig only with constants related to AppListItemView sizes within AppsGridView. Note that some of these constants are used to create a scaled AppListConfig when a base config would produce grid that does not fit available bounds. This CL hardcodes the constants in AppListConfigProvider, with a plan to remove them in a follow-up (where app list config factory function will be change to take available bounds instead of calculating it itself). BUG=1211592 Change-Id: If91936275e2aa8863c17407cea06fb287399c47c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200185 Commit-Queue: Toni Barzic <[email protected]> Reviewed-by: James Cook <[email protected]> Cr-Commit-Position: refs/heads/main@{#927509}
https://android.googlesource.com/platform/external/perfetto.git/+log/c10e58491f2a..23b1b0ba5f62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Iabb128f3b05145c91b1890867066c9a854b709c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200319 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#927510}
Replacing combined buildertester "Mac FYI GPU ASAN Release" deleted in crrev.com/c/3200452. The split testers serialize tests, reducing the load on Mac Retina AMD pool (as well as Mac Mini Intel pool). Caveats for testing/buildbot/test_suite_exceptions.pyl: 1. This enables info_collection_tests suite which was previously disabled because the old bot ran on 2 GPUs, so we couldn't give a single expectation. 2. This doesn't add is-asan argument for passthrough variants of WebGL tests, since this was the original state. Since we currently have some no-asan expectations which apply to this bot, I don't want to make changes at the moment. Bug: 1255237 Change-Id: I0b0d0da219e211cd5fa66804add4fea85830eb3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199212 Commit-Queue: Yuly Novikov <[email protected]> Reviewed-by: Brian Sheedy <[email protected]> Cr-Commit-Position: refs/heads/main@{#927511}
All changes were done automatically with git grep, sed, xargs, etc. No-Presubmit: true No-Try: true Bug: 1243777 Change-Id: I7cc197e9027f7837cd36afc67a209079f85ec364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198824 Commit-Queue: Peter Kasting <[email protected]> Owners-Override: Peter Kasting <[email protected]> Reviewed-by: Peter Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#927512}
Bug: 1095765 Change-Id: I676c1d5aa37a3e2afbed0fd0fc68581203a9bd2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200181 Commit-Queue: Xiaocheng Hu <[email protected]> Commit-Queue: Chris Harrelson <[email protected]> Auto-Submit: Xiaocheng Hu <[email protected]> Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/heads/main@{#927513}
# This is an automated release commit. # Do not revert without consulting [email protected]. NOAUTOREVERT=true Change-Id: I7182a67eca5c9ab1dab4c4ff13dbf91b4ac4793b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198221 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927514}
This was incorrectly changed during the migration to satisfy TS compiler. Add a workaround for the fact that TypeScript is missing this method definition. Change-Id: Ifca0a0bec4551352840f7f6f85615c1ed9f81adb Bug: 1253075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200237 Reviewed-by: John Lee <[email protected]> Commit-Queue: Rebekah Potter <[email protected]> Cr-Commit-Position: refs/heads/main@{#927515}
https://swiftshader.googlesource.com/SwiftShader.git/+log/f1aca9364038..f43b9df4c8a9 2021-10-02 [email protected] Add realms.cfg to LUCI configs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1068817 Tbr: [email protected] Change-Id: I9c3a80428358bdf2327bf5aeaf658e0ac68b56f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200695 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#927516}
…types X_USER_DATA_KEY_DECL() requires a semicolon while X_USER_DATA_KEY_IMPL() does not. This CL changes it so they both consistently require a semicolon. The comments have also been updated to: - reflect the updated macro usage to consistently require semicolons - simply the friend declaration, which does not need to qualify the base class template with the `content::` namespace nor explicitly specify the base class template's type parameter. Macro cleanups outside //content/public/browser were generated using the following commands: sed -z -i 's|\nNAVIGATION_HANDLE_USER_DATA_KEY_IMPL([ \n]*\([^)]\+\))|\nNAVIGATION_HANDLE_USER_DATA_KEY_IMPL(\1);|g' $(git gs NAVIGATION_HANDLE_USER_DATA_KEY_IMPL --name-only | grep -v navigation_handle_user_data.h) sed -z -i 's|\nPAGE_USER_DATA_KEY_IMPL([ \n]*\([^)]\+\))|\nPAGE_USER_DATA_KEY_IMPL(\1);|g' $(git gs PAGE_USER_DATA_KEY_IMPL --name-only | grep -v page_user_data.h) sed -z -i 's|\nRENDER_DOCUMENT_HOST_USER_DATA_KEY_IMPL([ \n]*\([^)]\+\))|\nRENDER_DOCUMENT_HOST_USER_DATA_KEY_IMPL(\1);|g' $(git gs RENDER_DOCUMENT_HOST_USER_DATA_KEY_IMPL --name-only | grep -v render_document_host_user_data.h) sed -z -i 's|\nWEB_CONTENTS_USER_DATA_KEY_IMPL([ \n]*\([^)]\+\))|\nWEB_CONTENTS_USER_DATA_KEY_IMPL(\1);|g' $(git gs WEB_CONTENTS_USER_DATA_KEY_IMPL --name-only | grep -v web_contents_user_data.h) Bug: 1254987 Change-Id: Ifbbc22108a17f4d3bcf5b6ae3e056d567c7cc4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198788 Reviewed-by: Nasko Oskov <[email protected]> Reviewed-by: Alexander Timin <[email protected]> Owners-Override: Nasko Oskov <[email protected]> Owners-Override: Alexander Timin <[email protected]> Commit-Queue: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/main@{#927517}
pull bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
https://chromium.googlesource.com/external/github.com/google/crc32c.git/+log/fa5ade41ee48..d3d60ac6e0f1 $ git log fa5ade41e..d3d60ac6e --date=short --no-merges --format='%ad %ae %s' 2024-09-06 davidben Fix invalid pointer casts in arm64 implementation (#65) 2024-09-06 shea C++ interface: Support std::byte if it's available. (#60) 2022-02-08 dimitris.apostolou Fix typo (#59) 2021-12-30 shrunkymunky Fix misspelled "Proccess" in comment 2021-10-05 costan Bump deps (#56) 2021-09-01 costan Fix Windows CI build. (#54) 2021-09-01 costan Switch CI to GitHub Actions (#55) 2021-08-30 pwnall Add clangd cache directory to .gitignore. Created with: roll-dep src/third_party/crc32c/src This picks up a fix for some UBSan errors. Bug: 40248746 Change-Id: Iab342ff34d52bb65969f2c4f90aafe6d539fb238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5842688 Commit-Queue: Ayu Ishii <[email protected]> Auto-Submit: David Benjamin <[email protected]> Reviewed-by: Ayu Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1352978}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )