Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

area w/ staticState === false that has been selected via API becomes unselected when clicking another area #366

Closed
techfg opened this issue Feb 7, 2021 · 0 comments · Fixed by #371
Closed

area w/ staticState === false that has been selected via API becomes unselected when clicking another area #366

techfg opened this issue Feb 7, 2021 · 0 comments · Fixed by #371
Labels
bug
Milestone
1.5.2

Comments

@techfg
Copy link
Collaborator

techfg commented Feb 7, 2021 •
edited
Loading

Describe the bug
When an area has staticState===false, if that area was programatically selected via select/set, unselecting a different area results in the staticState area becoming unselected.

To Reproduce
Steps to reproduce the behavior:

  1. Go to jsFiddle
  2. Click on Select Ringo button - ringo becomes selected
  3. Click on George area w/ mouse - that area becomes selected
  4. Click on George area w/ mouse - that area becomes selected but so does Ringo

Expected behavior
Ringo should remain selected

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A
@techfg techfg added the bug label Feb 7, 2021
@techfg techfg added this to the 1.5.2 milestone Feb 7, 2021
techfg added a commit that referenced this issue Feb 14, 2021
@techfg
Resolves #365 & #366 - fix staticState selected state
de59cc8
@techfg techfg mentioned this issue Feb 14, 2021
Merged
techfg added a commit that referenced this issue Feb 14, 2021
@techfg
Merge pull request #371 from jamietre/misc-fixes
d2c6c5f 
Resolves #137 - fix handling of href attribute empty/missing
Resolves #170 - fix missing/non-conforming shape attribute
Resolves #364 - fix uncaught promise when mouseoutDelay -1
Resolves #365 - fix selected state when `staticState === true`
Resolves #366 - fix selected state when `staticState === false`
Resolves #367 - fix options not correctly applied when calling set/selected API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.5.2
Development

Successfully merging a pull request may close this issue.

Misc fixes jamietre/ImageMapster
1 participant
@techfg