Export Clause and Clause Collection #116
Conversation
Making Builder extendable
ElMatella
changed the title
Export some of the internal classes to make it easier to integrate and extend. fix #116
|
Hi there, thanks for your suggestions. I created a new pull request to implement the changes you suggested as it looks like you had made some other changes in this pull request as well. Out of curiosity, what kind of extensions were you trying to make to the Builder class? |
## [5.0.1](v5.0.0...v5.0.1) (2019-12-08) ### Bug Fixes * export builder, clause and clause collection ([6dde494](6dde494)), closes [#116](#116) [skip ci]
|
🎉 This issue has been resolved in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Ho, yes thank you, I should have made this pull request from another branch on my fork. Thanks anyways! The extensions I was trying to make was some personal syntaxic helpers like "firstResult('n')" that would return the first n result. But nothing worth sharing really :/ I also wanted to get the Builder object to use my own connexion implementation. I did not see how to use transactions in your implementation as well |
First of all, thank you for your amazing job!
I tried to extend the Builder but could not because some exports were missing.
At first I tried to move all the clause things from the Query to the Builder class but could not make it work because of how generic is everything. This would have allowed us to use the Builder directly so we could extend it easily but it does not seem to work that way... And could not find on Google how to make chainable things without what you've done...
Anyways, here is a pull request to export the
ClauseCollectionand theClauseclasses.Have a nice day!