Fix for handleinputs and handletextareas being null #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -146,9 +146,12 @@ | |||
| handleInputs = node ? node.getElementsByTagName("input") : inputs; | |||
| handleTextareas = node ? node.getElementsByTagName("textarea") : textareas; | |||
|
|
|||
| var handleInputsLength = handleInputs ? handleInputs.length : 0; | |||
There was a problem hiding this comment.
Please follow the existing code conventions. Can you move the declarations up to the top of the function?
|
Thanks for this. I've added a couple of minor comments to the diff. If you can fix those then I'll merge this in for the next release. |
|
Noticing this issue as well when running our feature specs using PhantomJS. Will this fix be included in v3.0.2? |
jamesallardice
pushed a commit
that referenced
this pull request
Nov 29, 2013
Fix for handleinputs and handletextareas being null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IE, if handleInputs or handleTextAreas is undefined, a undefined error was being thrown on length. This checks that the item has a value before trying to use it