Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes jameelmoses/acf-flexible-content-extended#11 #12

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

romanklabal
Copy link
Contributor

This pull request fixes issue #11

To quickly test it, you can do the following:

  1. Create a new Field Group, call it First, add a Flexible Content field to it with a layout called first-one
  2. Verify that your plugin correctly shows the preview for first-one.jpg
  3. Duplicate the First Field Group using the inline action, rename it to Second, rename the layout from first-one to second-one
  4. If you test it now, you will see that one of the previews (either first-one.jpg or second-one.jpg) will be missing because the layouts have the same internal key and it has been skipped.

My PR solves this by combining the layout key with the flexible content key.

Copy link
Owner

@jameelmoses jameelmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks for contributing! I'll draft up a new release as soon as I can; likely toward the end of this week.

@jameelmoses jameelmoses merged commit 655ea87 into jameelmoses:master Aug 9, 2022
@romanklabal romanklabal deleted the fix-branch branch August 9, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants