Fix error when closing Core Lightning channels

[kelvinator07]

Closes #935

Description

• Used channel ID for Core lightning.
• Added unilaterally property with a value of 1 millisecond to the request body for closeChannel method.

Steps to Test

1. Create a network with the default selection (1 LND, 1 CLN, 1 Eclair, 1 Bitcoin Core nodes).
2. Start the network and create a channel using CLN as the originating node.
3. Close the channel by right-clicking on the channel link or using the Close channel button from the sidebar channel details menu.

[jamaljsr]

Hey @kelvinator07, thanks so much for finding this issue.

Do you think you'll have this PR ready in the next couple of days? I am pretty close to shipping a new release and would like to have this issue resolved before then. If you don't have the time to finish this then I can take it over to ensure it's included in the next release.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1169a7b) to head (475e4ea).

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #934   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          151       151           
  Lines         5490      5489    -1     
  Branches      1104      1104           
=========================================
- Hits          5490      5489    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kelvinator07]

Hi @jamaljsr, The PR is now ready for review. Thanks

[jamaljsr]

Thanks for the fix. I tested it and it works as expected. I just have some feedback on some of the implementation details.

[jamaljsr]

Thanks for those answers. This looks almost ready. I just left one remaining suggestion on the unit test changes that I think can be improved.

[jamaljsr]

Thanks for the updates. This looks good to go now 👌