-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Terminal (litd) #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #902 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 143 151 +8
Lines 4810 5485 +675
Branches 933 1060 +127
==========================================
+ Hits 4810 5485 +675 ☔ View full report in Codecov by Sentry. |
b6eb07e
to
0b303bb
Compare
c8df5e6
to
dc88a5f
Compare
f75a8c2
to
f5b8580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In anticipation of the upcoming release of Taproot Asset channels, I've added support for Terminal (litd) nodes in Polar. The asset channels will require
litd
to be created as well as to send & receive asset payments over lightning. This PR does not include any asset channel capabilities since those features have not been officially released by Lightning Labs yet. This just lays the foundation forlitd
support by adding the current latest version v012.5-alpha. A future update will add support for asset channel funding and payments.litd
nodes integratelnd
,tapd
, and others into a single daemon. In Polar, all of the existing Lightning and Taproot Assets functionality is made available for thelitd
nodes. Additionally, I've added support for creating Lightning Node Connect (LNC) sessions on thelitd
nodes, so you can easily test third-party apps connecting to the node over LNC.FYI: While
litd
does support Loop and Pool, those daemons have been disabled by default in Polar because they require backend coordination servers to function properly. Support for these services may be added in a future update.Screenshots