Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Terminal (litd) #902

Merged
merged 30 commits into from
Jun 20, 2024
Merged

Add support for Terminal (litd) #902

merged 30 commits into from
Jun 20, 2024

Conversation

jamaljsr
Copy link
Owner

@jamaljsr jamaljsr commented May 16, 2024

Description

In anticipation of the upcoming release of Taproot Asset channels, I've added support for Terminal (litd) nodes in Polar. The asset channels will require litd to be created as well as to send & receive asset payments over lightning. This PR does not include any asset channel capabilities since those features have not been officially released by Lightning Labs yet. This just lays the foundation for litd support by adding the current latest version v012.5-alpha. A future update will add support for asset channel funding and payments.

litd nodes integrate lnd, tapd, and others into a single daemon. In Polar, all of the existing Lightning and Taproot Assets functionality is made available for the litd nodes. Additionally, I've added support for creating Lightning Node Connect (LNC) sessions on the litd nodes, so you can easily test third-party apps connecting to the node over LNC.

FYI: While litd does support Loop and Pool, those daemons have been disabled by default in Polar because they require backend coordination servers to function properly. Support for these services may be added in a future update.

Screenshots

image

image

image

image

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f336eaf) to head (77140eb).

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #902    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          143       151     +8     
  Lines         4810      5485   +675     
  Branches       933      1060   +127     
==========================================
+ Hits          4810      5485   +675     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamaljsr jamaljsr force-pushed the feat/litd branch 3 times, most recently from b6eb07e to 0b303bb Compare May 16, 2024 15:12
@jamaljsr jamaljsr force-pushed the cln-24.02.2 branch 2 times, most recently from c8df5e6 to dc88a5f Compare June 8, 2024 07:45
@jamaljsr jamaljsr force-pushed the cln-24.02.2 branch 2 times, most recently from f75a8c2 to f5b8580 Compare June 18, 2024 06:27
Base automatically changed from cln-24.02.2 to master June 18, 2024 06:47
@jamaljsr jamaljsr changed the title Add support for Terminal (litd) v0.12.5-alpha Add support for Terminal (litd) Jun 20, 2024
@jamaljsr jamaljsr merged commit e2ae009 into master Jun 20, 2024
5 checks passed
@jamaljsr jamaljsr deleted the feat/litd branch June 20, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant