Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remember node counts when creating new networks #895

Merged
merged 1 commit into from
May 6, 2024

Conversation

jamaljsr
Copy link
Owner

@jamaljsr jamaljsr commented May 6, 2024

Description

When repeatedly creating new networks for testing, I often want to use the same count of nodes that I used on the previously created network. It's a minor annoyance to have to change the counts each time. This PR just saves the node counts when you create a new network and uses those values the next time you go to the New Network screen.

Steps to Test

  1. Click New Network
  2. Change the node counts to different values
  3. Click Create Network
  4. Delete the network
  5. Restart Polar
  6. Click New Network
  7. Confirm the initial node counts are what you previously set

@jamaljsr jamaljsr force-pushed the feat/remember-node-counts branch from d22aff5 to e7f8e3d Compare May 6, 2024 14:26
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c25b429) to head (e7f8e3d).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #895   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          140       140           
  Lines         4581      4582    +1     
  Branches       852       887   +35     
=========================================
+ Hits          4581      4582    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamaljsr jamaljsr merged commit 4b2c287 into master May 6, 2024
5 checks passed
@jamaljsr jamaljsr deleted the feat/remember-node-counts branch May 6, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant