-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terminal): change font size and copy/paste using key shortcuts #612
feat(terminal): change font size and copy/paste using key shortcuts #612
Conversation
Thanks for the PR. I'll try to review this later today or tomorrow at the latest. |
Can you rebase this on master. I noticed that there are a lot of dependency version downgrades in the package.json file. |
No problem |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 116 116
Lines 3413 3414 +1
Branches 612 612
=========================================
+ Hits 3413 3414 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the contribution. I left my feedback below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. I tested this and it works great functionally.
The only thing left to do is regarding the diff. Can you please perform the following before merge?
- Rebase on the
master
branch - Revert the changes to
package.json
,yarn.lock
, andtsconfig.json
since these do not need to change for this feature - Squash your commits down to a single one. It's not necessary to have multiple commits for a single file change
Feel free to reach out if you're having any trouble with these.
0960d57
to
8ba299f
Compare
Done, squashed into a single commit. Hope it can now be merged |
The diff looks great. I'm going to do a final sanity check on Mac/Win/Linux before merging. Hopefully will get that done tonight or tomorrow. |
Hey, so sorry but I just realized the Polar asciiart is now out of alignment. It looks like you removed the whitespace on line 45. Can you fix this please? |
BTW: I tested on all OS's so this is good to go once the whitespace is fixed. |
8ba299f
to
05bd5b3
Compare
No problem, fixed. For some reason, VSCode automatically removed this trailing newline. Anyway hope everything is okay now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to go. 👍 Thanks for your contribution.
💯 |
Closes #531
Description
Steps to Test
Screenshots